Use etcd-snapshot-retention as default for s3 if etcd-s3-retention is not set#13770
Merged
brandond merged 1 commit intok3s-io:mainfrom Mar 10, 2026
Merged
Conversation
2c310e6 to
26b4f99
Compare
dereknola
previously approved these changes
Mar 9, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13770 +/- ##
=======================================
Coverage 22.35% 22.35%
=======================================
Files 193 193
Lines 15606 15613 +7
=======================================
+ Hits 3488 3490 +2
- Misses 11639 11644 +5
Partials 479 479
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgfritch
previously approved these changes
Mar 10, 2026
26b4f99 to
a84e728
Compare
… not set Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
a84e728 to
5c960ed
Compare
mgfritch
approved these changes
Mar 10, 2026
vitorsavian
approved these changes
Mar 10, 2026
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use etcd-snapshot-retention as default for s3 if etcd-s3-retention is not set
Types of Changes
enhancement
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments