Skip to content

Use etcd-snapshot-retention as default for s3 if etcd-s3-retention is not set#13770

Merged
brandond merged 1 commit intok3s-io:mainfrom
brandond:s3-snapshot-retain-defaults
Mar 10, 2026
Merged

Use etcd-snapshot-retention as default for s3 if etcd-s3-retention is not set#13770
brandond merged 1 commit intok3s-io:mainfrom
brandond:s3-snapshot-retain-defaults

Conversation

@brandond
Copy link
Copy Markdown
Member

@brandond brandond commented Mar 9, 2026

Proposed Changes

Use etcd-snapshot-retention as default for s3 if etcd-s3-retention is not set

Types of Changes

enhancement

Verification

See linked issue

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner March 9, 2026 23:28
@brandond brandond force-pushed the s3-snapshot-retain-defaults branch from 2c310e6 to 26b4f99 Compare March 9, 2026 23:28
dereknola
dereknola previously approved these changes Mar 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.35%. Comparing base (3f5eec4) to head (5c960ed).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cli/etcdsnapshot/etcd_snapshot.go 0.00% 2 Missing ⚠️
pkg/cli/server/server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13770   +/-   ##
=======================================
  Coverage   22.35%   22.35%           
=======================================
  Files         193      193           
  Lines       15606    15613    +7     
=======================================
+ Hits         3488     3490    +2     
- Misses      11639    11644    +5     
  Partials      479      479           
Flag Coverage Δ
unittests 22.35% <20.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mgfritch
mgfritch previously approved these changes Mar 10, 2026
@brandond brandond dismissed stale reviews from mgfritch and dereknola via a84e728 March 10, 2026 18:09
@brandond brandond force-pushed the s3-snapshot-retain-defaults branch from 26b4f99 to a84e728 Compare March 10, 2026 18:09
… not set

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond force-pushed the s3-snapshot-retain-defaults branch from a84e728 to 5c960ed Compare March 10, 2026 18:38
@brandond brandond merged commit f4bb1e6 into k3s-io:main Mar 10, 2026
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants