Skip to content

Update packages to remove unmaintained dependencies#13724

Merged
brandond merged 3 commits intok3s-io:mainfrom
brandond:drop-deprecated
Mar 9, 2026
Merged

Update packages to remove unmaintained dependencies#13724
brandond merged 3 commits intok3s-io:mainfrom
brandond:drop-deprecated

Conversation

@brandond
Copy link
Copy Markdown
Member

@brandond brandond commented Mar 3, 2026

Proposed Changes

  • Update packages to remove dep on archived github.com/pkg/errors
  • Update packages to remove dep on unmaintained github.com/gorilla/mux
  • Replace merr.NewErrors with errors.Join

Waiting on:

Bumps rancher/wrangler, rancher/wharfie, and k3s-io/kine

Types of Changes

tech debt

Verification

check for no references to package in go.mod

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner March 3, 2026 22:15
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 19.20200% with 324 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.36%. Comparing base (8908d5f) to head (20f8d1f).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
pkg/agent/containerd/containerd.go 0.00% 22 Missing ⚠️
pkg/agent/config/config.go 0.00% 19 Missing ⚠️
pkg/util/errors/errors.go 19.04% 15 Missing and 2 partials ⚠️
pkg/agent/run.go 0.00% 15 Missing ⚠️
pkg/etcd/snapshot.go 0.00% 14 Missing ⚠️
pkg/agent/flannel/flannel.go 0.00% 13 Missing ⚠️
pkg/cluster/bootstrap.go 0.00% 13 Missing ⚠️
pkg/server/server.go 0.00% 13 Missing ⚠️
pkg/etcd/etcd.go 40.00% 12 Missing ⚠️
pkg/spegel/spegel.go 0.00% 12 Missing ⚠️
... and 55 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13724      +/-   ##
==========================================
+ Coverage   22.19%   22.36%   +0.17%     
==========================================
  Files         191      193       +2     
  Lines       15556    15606      +50     
==========================================
+ Hits         3453     3491      +38     
- Misses      11628    11636       +8     
- Partials      475      479       +4     
Flag Coverage Δ
unittests 22.36% <19.20%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

manuelbuil
manuelbuil previously approved these changes Mar 4, 2026
@brandond brandond changed the title Update packages to remove dep on archived github.com/pkg/errors Update packages to remove unmaintained dependencies Mar 4, 2026
@brandond brandond force-pushed the drop-deprecated branch 2 times, most recently from f010cbb to 3e8f53f Compare March 7, 2026 00:24
@brandond brandond requested review from a team and manuelbuil March 7, 2026 00:29
brandond added 2 commits March 7, 2026 02:33
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
manuelbuil
manuelbuil previously approved these changes Mar 9, 2026
mgfritch
mgfritch previously approved these changes Mar 9, 2026
@brandond brandond dismissed stale reviews from mgfritch and manuelbuil via 52d4a25 March 9, 2026 20:01
@brandond brandond requested review from manuelbuil and mgfritch March 9, 2026 20:09
mux is replaced with a simple wrapper around http.ServeMux with middleware chain support

Unfortunately github.com/rootless-containers/rootlesskit/pkg/parent
still uses it so we can't drop the indirect dep yet.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond merged commit 3f5eec4 into k3s-io:main Mar 9, 2026
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants