Skip to content

Remove flannel external-ip annotations when disabled#13431

Merged
brandond merged 1 commit intok3s-io:mainfrom
brandond:fix-flannel-external-ip-disable
Jan 7, 2026
Merged

Remove flannel external-ip annotations when disabled#13431
brandond merged 1 commit intok3s-io:mainfrom
brandond:fix-flannel-external-ip-disable

Conversation

@brandond
Copy link
Copy Markdown
Member

@brandond brandond commented Jan 6, 2026

Proposed Changes

Remove flannel external-ip annotations when disabled

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner January 6, 2026 20:05
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.59%. Comparing base (2ef2865) to head (5f27e89).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/agent/flannel/setup.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13431      +/-   ##
==========================================
- Coverage   21.60%   21.59%   -0.02%     
==========================================
  Files         189      189              
  Lines       15382    15391       +9     
==========================================
  Hits         3323     3323              
- Misses      11606    11615       +9     
  Partials      453      453              
Flag Coverage Δ
unittests 21.59% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brandond brandond merged commit 1f2f610 into k3s-io:main Jan 7, 2026
91 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants