Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the k3s token command help #11673

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented Jan 28, 2025

Proposed Changes

The k3s token CLI has 5 verbs. 4 relate to bootstrap tokens and 1 is about server tokens (rotate). Based on that, this PR removes some potential confusion in the CLI help by:

  • Removing the word "bootstrap" from the general usage description of the tool
  • Replacing "bootstrap" by "server" in the description of the "rotate" verb

Types of Changes

Bugfix

Verification

Execute k3s token command and verify that the help description has this PR' changes

Testing

Linked Issues

#11674

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner January 28, 2025 10:26
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.65%. Comparing base (3fcbac8) to head (bb5956e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11673      +/-   ##
==========================================
- Coverage   48.56%   47.65%   -0.91%     
==========================================
  Files         185      185              
  Lines       19344    19344              
==========================================
- Hits         9394     9218     -176     
- Misses       8608     8792     +184     
+ Partials     1342     1334       -8     
Flag Coverage Δ
e2etests 40.42% <100.00%> (-3.82%) ⬇️
inttests 34.99% <100.00%> (?)
unittests 17.00% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants