-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "k3s certificate check" clause for better test coverage #11485
Conversation
Signed-off-by: Derek Nola <[email protected]>
0d20cac
to
add4718
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11485 +/- ##
==========================================
- Coverage 47.87% 38.85% -9.03%
==========================================
Files 181 164 -17
Lines 18794 18238 -556
==========================================
- Hits 8998 7086 -1912
- Misses 8448 9948 +1500
+ Partials 1348 1204 -144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Nola <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh a tabwriter, fancy
…1485) * Add "k3s certificate check" clause for better test coverage Signed-off-by: Derek Nola <[email protected]> * Add table support to cert check Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
…1485) * Add "k3s certificate check" clause for better test coverage Signed-off-by: Derek Nola <[email protected]> * Add table support to cert check Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
…1485) * Add "k3s certificate check" clause for better test coverage Signed-off-by: Derek Nola <[email protected]> * Add table support to cert check Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
…1485) * Add "k3s certificate check" clause for better test coverage Signed-off-by: Derek Nola <[email protected]> * Add table support to cert check Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
* Add "k3s certificate check" clause for better test coverage Signed-off-by: Derek Nola <[email protected]> * Add table support to cert check Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
* Add "k3s certificate check" clause for better test coverage Signed-off-by: Derek Nola <[email protected]> * Add table support to cert check Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
* Add "k3s certificate check" clause for better test coverage Signed-off-by: Derek Nola <[email protected]> * Add table support to cert check Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
* Add "k3s certificate check" clause for better test coverage Signed-off-by: Derek Nola <[email protected]> * Add table support to cert check Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
Proposed Changes
k3s certificate check
CLI in testing.Types of Changes
Testing
Verification
Coverage report
Testing
Linked Issues
#11484
User-Facing Change
Further Comments