Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Branch Name logic for Dependabot and UpdateCLI pushes to k3s-io #11376

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Nov 26, 2024

Proposed Changes

  • Add more logic and checks around determining parent branch name for Docker Upgrade and Skew tests.
  • Extend timeout for etcd split role docker test, 5 nodes takes more than 60s

Types of Changes

CI Test Fix

Verification

CI is green.
Note that this branch is specifically prefixed with dependabot to simulate a typical dependabot branch name.
Additionally, this PR is from a branch on k3s-io not from my personal fork, just like the bots make.
https://github.com/k3s-io/k3s/actions/runs/12039503425

Testing

Linked Issues

#11374

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner November 26, 2024 21:58
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.84%. Comparing base (b5e2fa7) to head (f81053e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b5e2fa7) and HEAD (f81053e). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (b5e2fa7) HEAD (f81053e)
inttests 11 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11376      +/-   ##
==========================================
- Coverage   47.16%   39.84%   -7.32%     
==========================================
  Files         179      179              
  Lines       18600    18600              
==========================================
- Hits         8772     7412    -1360     
- Misses       8476    10096    +1620     
+ Partials     1352     1092     -260     
Flag Coverage Δ
e2etests 34.24% <ø> (-8.01%) ⬇️
inttests ?
unittests 13.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwayne18
Copy link
Member

/trivy

Copy link
Contributor

🌟 No High or Critical CVEs Found 🌟

@dereknola dereknola merged commit c669600 into master Nov 27, 2024
50 checks passed
@dereknola dereknola deleted the dependabot_skew_fix branch November 27, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants