Update coredns to 1.11.3 and metrics-server to 0.7.2 #10760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
Also, don't use "fixes" or "resolves" before an issue in your comment, as that will auto-close the issue. We need it left open for QA to validate and close. |
brandond
changed the title
brandond
previously approved these changes
Aug 29, 2024
dereknola
previously approved these changes
Aug 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10760 +/- ##
==========================================
- Coverage 49.83% 43.67% -6.17%
==========================================
Files 178 178
Lines 14753 14753
==========================================
- Hits 7352 6443 -909
- Misses 6062 7121 +1059
+ Partials 1339 1189 -150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
previously approved these changes
Aug 29, 2024
dereknola
previously approved these changes
Aug 29, 2024
Used https://github.com/coredns/corefile-migration to migrate the corefile. There are no changes for the default file from 1.10.1 to 1.11.3. Notable plugin changes include the k8s_external with fallthrough option and rewrite with cname_target option. These changes are not part of the default config that ships with k3s. Customers using these two plugins can start using the new options Metrics does not have any new features other than build tooling updates. Requires rancher/image-mirror#704 Signed-off-by: Harsimran Singh Maan <[email protected]>
brandond
approved these changes
Aug 29, 2024
dereknola
approved these changes
Aug 29, 2024
|
thanks for the PR! |
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Used https://github.com/coredns/corefile-migration to migrate the corefile. There are no changes for the default file from 1.10.1 to 1.11.3.
Notable plugin changes include the k8s_external with fallthrough option and rewrite with cname_target option.
These changes are not part of the default config that ships with k3s. Customers using these two plugins can start using the new options
Requires
Types of Changes
version bump
Verification
Check image version
Testing
Linked Issues
User-Facing Change
Further Comments