Add trivy scanning to PR reports #10758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10758 +/- ##
===========================================
- Coverage 49.59% 36.43% -13.16%
===========================================
Files 178 161 -17
Lines 14753 14262 -491
===========================================
- Hits 7317 5197 -2120
- Misses 6091 8036 +1945
+ Partials 1345 1029 -316
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Nola <[email protected]>
cwayne18
approved these changes
Aug 28, 2024
brandond
reviewed
Aug 29, 2024
| run: | | ||
| echo '```' | cat - trivy-report.txt > temp && mv temp trivy-report.txt | ||
| echo '```' >> trivy-report.txt | ||
| gh issue comment ${{ github.event.issue.number }} --edit-last -F trivy-report.txt |
There was a problem hiding this comment.
just out of curiosity - does this edit the last comment by the current user, or the last comment on the issue?
There was a problem hiding this comment.
It edits the last comment made by the user on that issue, in this case the user is the "github-actions bot"
brandond
approved these changes
Aug 29, 2024
|
Does this cover the entire airgap bundle or just the binary? There are generally more findings in the packaged images than k3s itself |
|
Just binaries built by or included in this repo. Basically anything in the rancher/k3s image. Scanning the mirrored images is handled elsewhere. |
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit fa6940d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit fa6940d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit fa6940d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit fa6940d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit fa6940d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit fa6940d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit fa6940d) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit fa6940d) Signed-off-by: Brad Davidson <[email protected]>
ludost
pushed a commit
to asimovo-platform/k3s
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Once this is merged, it allows user to comment
/trivyon a PR to trigger a build of K3s and a trivy reportThe report is run on an internal GHA
And eventually, the comment edited and replaced with the report
Types of Changes
CI
Verification
Verified on dereknola#25
Testing
N/A
Linked Issues
#10759
User-Facing Change
Further Comments