Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.31.0-k3s1 #10715

Merged
merged 8 commits into from
Aug 22, 2024
Merged

v1.31.0-k3s1 #10715

merged 8 commits into from
Aug 22, 2024

Conversation

galal-hussein
Copy link
Contributor

@galal-hussein galal-hussein commented Aug 14, 2024

Proposed Changes

  • Fix kubelet util calls
  • Update cri-dockerd
  • Update K8s to 1.31
  • Fix to secrets encryption metrics (ALPHA metrics were deprecated in 1.30, removed 1.31, will backport commit to 1.30)
  • Update various go dependencies to match upstream

Types of Changes

New Minor Release

Verification

CI Green

Testing

Linked Issues

User-Facing Change


Further Comments

@galal-hussein galal-hussein requested a review from a team as a code owner August 14, 2024 20:47
dereknola
dereknola previously approved these changes Aug 14, 2024
brandond
brandond previously approved these changes Aug 14, 2024
Signed-off-by: galal-hussein <[email protected]>
@dereknola
Copy link
Member

Looks like the generated go is changed, causing the DIRTY validation failure

@brandond
Copy link
Member

Oof yeah there's a BUNCH of changes to codegen, I wonder if this will require changes on the wrangler side.

Signed-off-by: galal-hussein <[email protected]>
Signed-off-by: galal-hussein <[email protected]>
@brandond
Copy link
Member

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 43.73%. Comparing base (649678b) to head (ceee1af).
Report is 10 commits behind head on master.

Files Patch % Lines
...ped/k3s.cattle.io/v1/fake/fake_etcdsnapshotfile.go 0.00% 21 Missing ⚠️
...ersioned/typed/k3s.cattle.io/v1/fake/fake_addon.go 0.00% 17 Missing ⚠️
pkg/secretsencrypt/config.go 0.00% 9 Missing ⚠️
...lientset/versioned/typed/k3s.cattle.io/v1/addon.go 0.00% 7 Missing ⚠️
...rsioned/typed/k3s.cattle.io/v1/etcdsnapshotfile.go 0.00% 7 Missing ⚠️
pkg/agent/https/https.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (649678b) and HEAD (ceee1af). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (649678b) HEAD (ceee1af)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10715      +/-   ##
==========================================
- Coverage   49.58%   43.73%   -5.86%     
==========================================
  Files         179      179              
  Lines       14979    14829     -150     
==========================================
- Hits         7428     6485     -943     
- Misses       6187     7149     +962     
+ Partials     1364     1195     -169     
Flag Coverage Δ
e2etests 36.22% <0.00%> (-10.09%) ⬇️
inttests 19.64% <0.00%> (-17.05%) ⬇️
unittests 13.52% <0.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond
Copy link
Member

@dereknola can you include a bump to https://github.com/k3s-io/kine/releases/tag/v0.12.0

Signed-off-by: Derek Nola <[email protected]>
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on version script change

scripts/version.sh Outdated Show resolved Hide resolved
Co-authored-by: Brad Davidson <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
brandond
brandond previously approved these changes Aug 21, 2024
@dereknola dereknola merged commit c7468ed into k3s-io:master Aug 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants