-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.31.0-k3s1 #10715
v1.31.0-k3s1 #10715
Conversation
Signed-off-by: galal-hussein <[email protected]>
9c08a27
to
0f2e6e1
Compare
Looks like the generated go is changed, causing the DIRTY validation failure |
Oof yeah there's a BUNCH of changes to codegen, I wonder if this will require changes on the wrangler side. |
Signed-off-by: galal-hussein <[email protected]>
Signed-off-by: galal-hussein <[email protected]>
Signed-off-by: galal-hussein <[email protected]>
de6410b
to
05c8c0e
Compare
We're going to need to bump kine as well: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10715 +/- ##
==========================================
- Coverage 49.58% 43.73% -5.86%
==========================================
Files 179 179
Lines 14979 14829 -150
==========================================
- Hits 7428 6485 -943
- Misses 6187 7149 +962
+ Partials 1364 1195 -169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Nola <[email protected]>
05c8c0e
to
144340e
Compare
@dereknola can you include a bump to https://github.com/k3s-io/kine/releases/tag/v0.12.0 |
Signed-off-by: Derek Nola <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit on version script change
Co-authored-by: Brad Davidson <[email protected]> Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Proposed Changes
Types of Changes
New Minor Release
Verification
CI Green
Testing
Linked Issues
User-Facing Change
Further Comments