Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching name for e2e vagrant box #10695

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

dereknola
Copy link
Member

Proposed Changes

Addendum to #10681, update the cache key used for e2e boxes in CI

Types of Changes

Bug fix

Verification

CI green

Testing

Linked Issues

N/A

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner August 12, 2024 16:56
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.27%. Comparing base (ac247d2) to head (bd99079).

❗ There is a different number of reports uploaded between BASE (ac247d2) and HEAD (bd99079). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (ac247d2) HEAD (bd99079)
unittests 1 0
inttests 10 0
e2etests 7 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10695       +/-   ##
===========================================
- Coverage   49.56%   36.27%   -13.29%     
===========================================
  Files         179      162       -17     
  Lines       14955    14309      -646     
===========================================
- Hits         7412     5191     -2221     
- Misses       6184     8087     +1903     
+ Partials     1359     1031      -328     
Flag Coverage Δ
e2etests 36.27% <ø> (-10.08%) ⬇️
inttests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 38df767 into k3s-io:master Aug 13, 2024
17 checks passed
@dereknola dereknola deleted the cache_name_fix branch August 30, 2024 16:26
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit that referenced this pull request Sep 4, 2024
dereknola added a commit that referenced this pull request Sep 4, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 6, 2024
dereknola added a commit that referenced this pull request Sep 6, 2024
ludost pushed a commit to asimovo-platform/k3s that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants