Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.29] Backports for August 2024 #10672

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Aug 5, 2024

Proposed Changes

Backports:

Types of Changes

Verification

Testing

Linked Issues

#10634
#10638

User-Facing Change


Further Comments

* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
* Use higher QPS for secrets reencryption

Signed-off-by: Derek Nola <[email protected]>
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola requested a review from a team as a code owner August 5, 2024 17:06
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 43.36%. Comparing base (429d00a) to head (76ffa7a).

Files Patch % Lines
pkg/agent/run.go 0.00% 4 Missing and 2 partials ⚠️
pkg/secretsencrypt/controller.go 0.00% 6 Missing ⚠️
pkg/daemons/control/server.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (429d00a) and HEAD (76ffa7a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (429d00a) HEAD (76ffa7a)
e2etests 7 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #10672      +/-   ##
================================================
- Coverage         49.85%   43.36%   -6.50%     
================================================
  Files               179      179              
  Lines             14945    14952       +7     
================================================
- Hits               7451     6484     -967     
- Misses             6139     7271    +1132     
+ Partials           1355     1197     -158     
Flag Coverage Δ
e2etests 36.32% <0.00%> (-10.27%) ⬇️
inttests 19.68% <0.00%> (-17.08%) ⬇️
unittests 13.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 5516160 into k3s-io:release-1.29 Aug 6, 2024
29 checks passed
@dereknola dereknola deleted the slim_hard_129 branch August 12, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants