Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.28] Fixing setproctitle function #10624

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Jul 31, 2024

(cherry picked from commit bf6e874)

Proposed Changes

Fix setproctitle wrapper to not always set title to "agent"
Commit was missed from previous round of backports.

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: galal-hussein <[email protected]>
(cherry picked from commit bf6e874)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner July 31, 2024 23:25
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.79%. Comparing base (21794b9) to head (8bc2418).
Report is 3 commits behind head on release-1.28.

❗ There is a different number of reports uploaded between BASE (21794b9) and HEAD (8bc2418). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (21794b9) HEAD (8bc2418)
unittests 2 0
e2etests 13 6
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.28   #10624       +/-   ##
=================================================
- Coverage         45.85%   35.79%   -10.07%     
=================================================
  Files               165      162        -3     
  Lines             16811    14179     -2632     
=================================================
- Hits               7709     5075     -2634     
- Misses             7788     8108      +320     
+ Partials           1314      996      -318     
Flag Coverage Δ
e2etests 35.79% <100.00%> (-11.33%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 7f80d18 into k3s-io:release-1.28 Aug 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants