Refactor chart controller logic #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiyengar2
force-pushed
the
final_refactor
branch
4 times, most recently
from
59333ce
to
7567965
Compare
added 22 commits
September 8, 2022 00:09
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit aac8da5) Signed-off-by: Arvind Iyengar <[email protected]>
…wn function Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit d4d3060) Signed-off-by: Arvind Iyengar <[email protected]>
…ollers/common Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 6c257fd) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 2ad0fb7) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit b46d00f) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 018e29e) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 0211caa) Signed-off-by: Arvind Iyengar <[email protected]>
…cache provided Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 16b8c74) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit a330e3f) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 2065aa6) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 0867e35) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit f153a6a) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit f9e9ee9) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 43b93e9) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 40224d7) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit e0dbaae) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 5a6e7ce) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit 0553fb1) Signed-off-by: Arvind Iyengar <[email protected]>
… same namespace Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit c1b9270) Signed-off-by: Arvind Iyengar <[email protected]>
…onflicts Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit a3cff64) Signed-off-by: Arvind Iyengar <[email protected]>
…ts, not all Signed-off-by: Arvind Iyengar <[email protected]> (cherry picked from commit de8849b) Signed-off-by: Arvind Iyengar <[email protected]>
Signed-off-by: Arvind Iyengar <[email protected]>
aiyengar2
force-pushed
the
final_refactor
branch
from
7567965
to
96f5f6a
Compare
|
There's still a lot here but I think I grok it and it looks good. Would it be possible to add some e2e tests that confirm what happens when you upgrade from an older version of the helm controller, to this newly rewritten release? I want to be sure we don't run into problems in K3s and RKE2 when we pull this in. When we tag it for release we should also jump up to 1.0 or something, so that we can continue to release off a legacy branch in case we run into problems. |
brandond
approved these changes
Oct 20, 2022
|
Have socialized this change to the team on multiple occasions and not received any additional feedback; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 6 of #141