Repository navigation
Update DPDFNet documentation - #845
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
csukuangfj
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/onnx/speech-enhancement/dpdfnet.rst`:
- Around line 115-117: Update the download commands in the DPDFNet documentation
to reference valid, published model asset URLs. Verify all three 8 kHz and 48
kHz links resolve successfully before retaining them in the instructions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5eb96f8d-a11c-43dd-a2e4-653f5203b4ea
📒 Files selected for processing (7)
docs/source/onnx/javascript-api/examples/api_speech_denoiser.rstdocs/source/onnx/javascript-api/examples/speech_enhancement.rstdocs/source/onnx/rust-api/examples/offline_speech_enhancement_dpdfnet.rstdocs/source/onnx/rust-api/examples/streaming_speech_enhancement_dpdfnet.rstdocs/source/onnx/speech-enhancement/dpdfnet-c-api.rstdocs/source/onnx/speech-enhancement/dpdfnet-python-api.rstdocs/source/onnx/speech-enhancement/dpdfnet.rst
| wget https://github.com/k2-fsa/sherpa-onnx/releases/download/speech-enhancement-models/dpdfnet2_8khz.onnx | ||
| wget https://github.com/k2-fsa/sherpa-onnx/releases/download/speech-enhancement-models/dpdfnet8_8khz.onnx | ||
| wget https://github.com/k2-fsa/sherpa-onnx/releases/download/speech-enhancement-models/dpdfnet8_48khz_hr.onnx |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -eu
base="https://github.com/k2-fsa/sherpa-onnx/releases/download/speech-enhancement-models"
for model in \
dpdfnet2_8khz.onnx \
dpdfnet8_8khz.onnx \
dpdfnet8_48khz_hr.onnx
do
status="$(curl -L -s -o /dev/null -w '%{http_code}' "$base/$model")"
test "$status" = 200 || {
echo "$model: HTTP $status"
exit 1
}
doneRepository: k2-fsa/sherpa
Length of output: 180
🏁 Script executed:
#!/bin/bash
base="https://github.com/k2-fsa/sherpa-onnx/releases/download/speech-enhancement-models"
for model in dpdfnet2_8khz.onnx dpdfnet8_8khz.onnx dpdfnet8_48khz_hr.onnx; do
status="$(curl -L -s -o /dev/null -w '%{http_code}' "$base/$model")"
printf '%s: HTTP %s\n' "$model" "$status"
doneRepository: k2-fsa/sherpa
Length of output: 242
Publish or replace the new model assets before merging.
All three release URLs return HTTP 404. The download instructions are unusable.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/source/onnx/speech-enhancement/dpdfnet.rst` around lines 115 - 117,
Update the download commands in the DPDFNet documentation to reference valid,
published model asset URLs. Verify all three 8 kHz and 48 kHz links resolve
successfully before retaining them in the instructions.
|
Thanks @csukuangfj for the quick merge! :) Just to make sure this doesn’t fall through the cracks - will you also download the new/updated models and add them to the repo? The models are:
|
Summary
Update the DPDFNet documentation to reflect the changes introduced in
k2-fsa/sherpa-onnx #3824.
The documentation now:
Summary by CodeRabbit