add WebAssembly for Kws #648
Conversation
| ``` | ||
|
|
||
| You should have the following files in `assets` before you can run | ||
| `build-wasm-simd-kws.sh` |
There was a problem hiding this comment.
Please also check in this file.
You need to use
cd sherpa-onnx
git add -f ./build-wasm-simd-kws.sh
|
|
||
| #ifdef SHERPA_ONNX_ENABLE_WASM_KWS | ||
| // Due to the limitations of the wasm file system, |
There was a problem hiding this comment.
Could you pass a keyword file from wasm?
We have been doing this for model files, such as tokens.txt.
There was a problem hiding this comment.
Sure, but it needs to be recompiled when the keywords is modified, which is very inconvenient. Because token.txt and keywords.txt are both packaged into the sherpa-onnx-wasm-kws-main.data file, they cannot be modified and can only be recompiled to generate. What do you think?
There was a problem hiding this comment.
Ah, I see. Then please keep using your current approach.
wasm/kws/CMakeLists.txt
Outdated
| @@ -0,0 +1,55 @@ | |||
| if(NOT $ENV{SHERPA_ONNX_IS_USING_BUILD_WASM_SH}) | |||
| message(FATAL_ERROR "Please use ./build-wasm-kws.sh to build for wasm KWS") | |||
There was a problem hiding this comment.
| message(FATAL_ERROR "Please use ./build-wasm-kws.sh to build for wasm KWS") | |
| message(FATAL_ERROR "Please use ./build-wasm-simd-kws.sh to build for wasm KWS") |
| @@ -17,14 +17,13 @@ concurrency: | |||
|
|
|||
| jobs: | |||
| build_wheels_aarch64: | |||
| name: ${{ matrix.manylinux }} ${{ matrix.python-version }} | |||
| name: ${{ matrix.python-version }} | |||
There was a problem hiding this comment.
Please use changes from the latest master for *.yaml files that you have changed.
There was a problem hiding this comment.
sorry, I forgot to merge other files
sherpa-onnx/c-api/c-api.cc
Outdated
| @@ -473,10 +473,16 @@ SherpaOnnxKeywordSpotter* CreateKeywordSpotter( | |||
| SHERPA_ONNX_LOGE("%s\n", spotter_config.ToString().c_str()); | |||
| } | |||
|
|
|||
| #ifndef SHERPA_ONNX_ENABLE_WASM_KWS | |||
There was a problem hiding this comment.
Could you disable only the check for hotword file?
We can still validate model files and tokens.txt.
There was a problem hiding this comment.
ok, thank you for your suggestions
|
Thank your for your first-time contribution! |
No description provided.