Repository navigation
Add Flutter/Dart Web support via WebAssembly #3842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1d6fb66
Remove pthread support from WebAssembly.
csukuangfj ee3425b
Update emsdk to 4.0.23
csukuangfj cbe8e9a
Add Dart Web support
csukuangfj ce59eb5
Refactor
csukuangfj 63d00d3
Refactor
csukuangfj 16a386e
More refactor
csukuangfj bc7d1be
Remove duplicate code
csukuangfj bb67c4c
Fix bugs with num_threads>1
csukuangfj 2c281d3
First working version
csukuangfj 8096ed4
Support pocket tts
csukuangfj 5db1e93
Refactor
csukuangfj c838fed
Refactor CI
csukuangfj 41c9cfa
Add missing directory
csukuangfj 895b22d
Fix CI
csukuangfj 242830f
Small fixes
csukuangfj 496df68
Fix CI
csukuangfj 840bc82
Merge remote-tracking branch 'dan/master' into dart-wasm
csukuangfj f89f865
Fixes after review
csukuangfj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Restore the disabled build and release jobs.
if: falseskips every listed matrix. This prevents these jobs from building and publishing macOS and Windows artifacts..github/workflows/flutter-macos.yaml#L19-L19: Remove the unconditional guard from the ASR job..github/workflows/flutter-macos.yaml#L133-L133: Remove the unconditional guard from the TTS job..github/workflows/flutter-windows-x64.yaml#L19-L19: Remove the unconditional guard from the ASR job..github/workflows/flutter-windows-x64.yaml#L125-L125: Remove the unconditional guard from the TTS job.🧰 Tools
🪛 actionlint (1.7.12)
[error] 19-19: constant expression "false" in condition. remove the if: section
(if-cond)
📍 Affects 2 files
.github/workflows/flutter-macos.yaml#L19-L19(this comment).github/workflows/flutter-macos.yaml#L133-L133.github/workflows/flutter-windows-x64.yaml#L19-L19.github/workflows/flutter-windows-x64.yaml#L125-L125🤖 Prompt for AI Agents
Source: Linters/SAST tools