Fix macOS release code signatures - #3794
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe macOS release workflow adds recursive signing and strict verification for Mach-O files, then applies it to main, library, and per-architecture package directories before creating ChangesmacOS artifact signing
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
csukuangfj
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Summary
codesign --verify --strictbefore archivingVerification
b4e5d097...)sherpa-onnx-versionsuccessfully from the repaired arm64 treeactionlintandshellcheckpassed for the changed workflow/helperFixes #3790
Summary by CodeRabbit