Skip to content

Fix installing espeak-ng-data directory - #3708

Merged
csukuangfj merged 1 commit into
k2-fsa:masterfrom
csukuangfj:fix-espeak-ng-install
Jun 29, 2026
Merged

csukuangfj merged 1 commit into
k2-fsa:masterfrom
csukuangfj:fix-espeak-ng-install

Conversation

@csukuangfj

Copy link
Copy Markdown
Collaborator

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 29, 2026
@csukuangfj
csukuangfj merged commit bbeb79e into k2-fsa:master Jun 29, 2026
25 of 26 checks passed
@csukuangfj
csukuangfj deleted the fix-espeak-ng-install branch June 29, 2026 10:32

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'piper-phonemize' dependency in CMake to a newer commit hash and updates its SHA256 checksum. Feedback recommends restoring the fallback mirror URL ('piper_phonemize_URL2') with the updated commit hash to ensure build reliability when GitHub is inaccessible. Additionally, the reviewer suggests removing a non-portable, environment-specific absolute path from the list of possible local file locations.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +4 to +5
set(piper_phonemize_URL "https://github.com/csukuangfj/piper-phonemize/archive/f3ff95afc03640bc1399e113e83361192a2fafb4.zip")
set(piper_phonemize_HASH "SHA256=d9cca4e2bdc7d6dd8dffb96a4668283dbd3f77a9c194a3e530c1e8eba9406a5d")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fallback mirror URL (piper_phonemize_URL2) was removed. Removing the mirror URL prevents successful builds in environments where GitHub is inaccessible or slow. Consider keeping the mirror URL and updating it to the new commit hash.

  set(piper_phonemize_URL  "https://github.com/csukuangfj/piper-phonemize/archive/f3ff95afc03640bc1399e113e83361192a2fafb4.zip")
  set(piper_phonemize_URL2 "https://hf-mirror.com/csukuangfj/sherpa-onnx-cmake-deps/resolve/main/piper-phonemize-f3ff95afc03640bc1399e113e83361192a2fafb4.zip")
  set(piper_phonemize_HASH "SHA256=d9cca4e2bdc7d6dd8dffb96a4668283dbd3f77a9c194a3e530c1e8eba9406a5d")

Comment on lines +13 to +14
/tmp/piper-phonemize-f3ff95afc03640bc1399e113e83361192a2fafb4.zip
/star-fj/fangjun/download/github/piper-phonemize-f3ff95afc03640bc1399e113e83361192a2fafb4.zip

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The absolute path /star-fj/fangjun/download/github/... is specific to a local development environment and is not portable. It should be removed from the list of possible file locations to keep the CMake configuration clean and generic.

    /tmp/piper-phonemize-f3ff95afc03640bc1399e113e83361192a2fafb4.zip

Comment on lines 27 to 29
URL
${piper_phonemize_URL}
${piper_phonemize_URL2}
URL_HASH ${piper_phonemize_HASH}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Add the fallback mirror URL (piper_phonemize_URL2) back to FetchContent_Declare to ensure that the build can fall back to the mirror if the primary GitHub URL is unreachable.

    URL
      ${piper_phonemize_URL}
      ${piper_phonemize_URL2}
    URL_HASH          ${piper_phonemize_HASH}

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant