Fix installing espeak-ng-data directory - #3708
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the 'piper-phonemize' dependency in CMake to a newer commit hash and updates its SHA256 checksum. Feedback recommends restoring the fallback mirror URL ('piper_phonemize_URL2') with the updated commit hash to ensure build reliability when GitHub is inaccessible. Additionally, the reviewer suggests removing a non-portable, environment-specific absolute path from the list of possible local file locations.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| set(piper_phonemize_URL "https://github.com/csukuangfj/piper-phonemize/archive/f3ff95afc03640bc1399e113e83361192a2fafb4.zip") | ||
| set(piper_phonemize_HASH "SHA256=d9cca4e2bdc7d6dd8dffb96a4668283dbd3f77a9c194a3e530c1e8eba9406a5d") |
There was a problem hiding this comment.
The fallback mirror URL (piper_phonemize_URL2) was removed. Removing the mirror URL prevents successful builds in environments where GitHub is inaccessible or slow. Consider keeping the mirror URL and updating it to the new commit hash.
set(piper_phonemize_URL "https://github.com/csukuangfj/piper-phonemize/archive/f3ff95afc03640bc1399e113e83361192a2fafb4.zip")
set(piper_phonemize_URL2 "https://hf-mirror.com/csukuangfj/sherpa-onnx-cmake-deps/resolve/main/piper-phonemize-f3ff95afc03640bc1399e113e83361192a2fafb4.zip")
set(piper_phonemize_HASH "SHA256=d9cca4e2bdc7d6dd8dffb96a4668283dbd3f77a9c194a3e530c1e8eba9406a5d")
| /tmp/piper-phonemize-f3ff95afc03640bc1399e113e83361192a2fafb4.zip | ||
| /star-fj/fangjun/download/github/piper-phonemize-f3ff95afc03640bc1399e113e83361192a2fafb4.zip |
There was a problem hiding this comment.
The absolute path /star-fj/fangjun/download/github/... is specific to a local development environment and is not portable. It should be removed from the list of possible file locations to keep the CMake configuration clean and generic.
/tmp/piper-phonemize-f3ff95afc03640bc1399e113e83361192a2fafb4.zip
| URL | ||
| ${piper_phonemize_URL} | ||
| ${piper_phonemize_URL2} | ||
| URL_HASH ${piper_phonemize_HASH} |
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
See #3171 (comment)
cc @ljnhst