Repository navigation
Release v1.13.2 - #3613
Merged
Merged
Release v1.13.2#3613
Conversation
dosubot
Bot
added
the
size:M
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (81)
📝 WalkthroughWalkthroughVersion bump from 1.13.1 to 1.13.2 across the entire Sherpa ONNX project: CMake and C++ build metadata, changelog, Android/iOS/macOS app versions, Flutter plugins and examples, Dart examples, HarmonyOS packages, Rust crates, Python wheels, Node.js packages, Maven projects, and all supporting documentation. ChangesVersion Bump 1.13.1 to 1.13.2
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version from 1.13.1 to 1.13.2 across all relevant configuration files, including Android, iOS, HarmonyOS, Rust, Python, Dart, and Flutter, and updates the internal version metadata. A review comment suggests simplifying the new_version variable in new-release.sh by removing unnecessary backslashes to ensure better portability in sed commands.
| old_version="1\.13\.0" | ||
| new_version="1\.13\.1" | ||
| old_version="1\.13\.1" | ||
| new_version="1\.13\.2" |
There was a problem hiding this comment.
The new_version variable is used as the replacement string in several sed commands throughout this script. In the replacement part of a sed substitution (s/find/replace/), backslashes are typically used to escape special characters like &, \, or the delimiter itself. Including backslashes to escape dots (e.g., 1\.13\.2) is unnecessary and non-portable; while some sed implementations might strip them, others may treat them literally, which could result in literal backslashes being inserted into the version strings of your configuration files. It is safer to use the literal version string for the replacement.
Suggested change
| new_version="1\.13\.2" | |
| new_version="1.13.2" |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit