Release v1.12.40 - #3548
Merged
Merged
Release v1.12.40#3548
Conversation
dosubot
Bot
added
the
size:M
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (81)
📝 WalkthroughWalkthroughVersion release 1.12.40 across the project: CHANGELOG entry added, build system versions incremented, and dependency versions updated consistently in Android, Flutter, Dart, Rust, iOS, macOS, HarmonyOS, Node.js, and Python package manifests. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive version bump from 1.12.39 to 1.12.40 across the entire repository, affecting build configurations for Android, iOS, Rust, Dart, Python, and HarmonyOS. The CHANGELOG was updated to include new Piper TTS models, Albanian support, and various bug fixes. Feedback was provided regarding the release script to improve the portability of version string replacement by removing unnecessary escape characters in the replacement variable.
| old_version="1\.12\.38" | ||
| new_version="1\.12\.39" | ||
| old_version="1\.12\.39" | ||
| new_version="1\.12\.40" |
There was a problem hiding this comment.
The new_version variable is used as the replacement string in sed commands throughout this script. While backslashes are necessary in the old_version variable to escape dots for the regex search pattern, they are not needed in the replacement string. Including them can lead to literal backslashes being inserted into files depending on the sed implementation (for example, BSD sed on macOS often treats \. in the replacement string as a literal \.). It is safer and more portable to use the literal version string for new_version.
Suggested change
| new_version="1\.12\.40" | |
| new_version="1.12.40" |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements