Skip to content

Fix warnings in Go API #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csukuangfj merged 1 commit into from
Mar 26, 2026
Merged

Fix warnings in Go API #3414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 16 additions & 84 deletions scripts/go/sherpa_onnx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1385,48 +1385,14 @@ func (tts *OfflineTts) GenerateWithZipvoice(
speed float32,
numSteps int,
) *GeneratedAudio {

cText := C.CString(text)
defer C.free(unsafe.Pointer(cText))

cPromptText := C.CString(promptText)
defer C.free(unsafe.Pointer(cPromptText))

var p *C.float
var n C.int
if len(promptSamples) > 0 {
p = (*C.float)(unsafe.Pointer(&promptSamples[0]))
n = C.int(len(promptSamples))
}

audio := C.SherpaOnnxOfflineTtsGenerateWithZipvoice(
tts.impl,
cText,
cPromptText,
p,
n,
C.int(promptSampleRate),
C.float(speed),
C.int(numSteps),
)
if audio == nil {
return nil
cfg := &GenerationConfig{
Speed: speed,
NumSteps: numSteps,
ReferenceAudio: promptSamples,
ReferenceSampleRate: promptSampleRate,
ReferenceText: promptText,
}
defer C.SherpaOnnxDestroyOfflineTtsGeneratedAudio(audio)

nn := int(audio.n)
arr := unsafe.Slice(
(*float32)(unsafe.Pointer(audio.samples)),
nn,
)

ans := &GeneratedAudio{
SampleRate: int(audio.sample_rate),
Samples: make([]float32, nn),
}
copy(ans.Samples, arr)

return ans
return tts.GenerateWithConfig(text, cfg, nil)
}

func (tts *OfflineTts) GenerateWithCallback(
Expand All @@ -1435,53 +1401,19 @@ func (tts *OfflineTts) GenerateWithCallback(
speed float32,
cb sherpaOnnxGeneratedAudioCallbackWithArg,
) *GeneratedAudio {

s := C.CString(text)
defer C.free(unsafe.Pointer(s))

var audio *C.struct_SherpaOnnxGeneratedAudio

if cb != nil {
h := cgo.NewHandle(cb)
defer h.Delete()

audio = C.SherpaOnnxOfflineTtsGenerateWithCallbackWithArg(
tts.impl,
s,
C.int(sid),
C.float(speed),
C.SherpaOnnxGeneratedAudioCallbackWithArg(C._cgoGeneratedAudioCallback),
unsafe.Pointer(&h),
)
} else {
audio = C.SherpaOnnxOfflineTtsGenerateWithCallbackWithArg(
tts.impl,
s,
C.int(sid),
C.float(speed),
nil,
nil,
)
cfg := &GenerationConfig{
Speed: speed,
Sid: sid,
}

if audio == nil {
return nil
}
defer C.SherpaOnnxDestroyOfflineTtsGeneratedAudio(audio)

n := int(audio.n)
samples := unsafe.Slice(
(*float32)(unsafe.Pointer(audio.samples)),
n,
)

ans := &GeneratedAudio{
SampleRate: int(audio.sample_rate),
Samples: make([]float32, n),
var pcb sherpaOnnxGeneratedAudioProgressCallbackWithArg
if cb != nil {
pcb = func(samples []float32, _ float32) bool {
return cb(samples)
}
}
copy(ans.Samples, samples)

return ans
return tts.GenerateWithConfig(text, cfg, pcb)
}

func (tts *OfflineTts) GenerateWithProgressCallback(
Expand Down