Repository navigation
Release v1.12.28 - #3250
Merged
Merged
Release v1.12.28#3250
Conversation
dosubot
Bot
added
the
size:M
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (57)
📝 WalkthroughWalkthroughVersion bump from 1.12.27 to 1.12.28 applied across the entire repository. Updates include build configuration files, Android app manifests, package specifications (Dart, Flutter, Python, Node.js), Harmony OS packages, iOS podspecs, C++ version constants, and changelog documentation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request marks the release of version Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares for the v1.12.28 release. It consists of a comprehensive version bump from v1.12.27 to v1.12.28 across the entire repository. The changes include updating the changelog, build scripts, configuration files, and dependency versions in various package managers. The updates are consistent and appear to be correctly applied for the new release.
There was a problem hiding this comment.
Pull request overview
Bumps repository and downstream package versions to v1.12.28 and updates release metadata/artifacts references for the v1.12.28 release.
Changes:
- Update version strings / dependency pins across C++, Python, Node.js, Dart/Flutter, Android, iOS/macOS, and Harmony OS packaging.
- Refresh release automation metadata (version codes, git date/sha, download URLs).
- Add 1.12.28 release notes to
CHANGELOG.md.
Reviewed changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sherpa-onnx/csrc/version.cc | Update embedded git date/SHA and version string to 1.12.28 |
| setup.py | Pin sherpa-onnx-core dependency to 1.12.28 (split package path) |
| scripts/wheel/sherpa-onnx-core/setup.py | Bump core wheel version to 1.12.28 |
| scripts/wheel/sherpa-onnx-bin/setup.py | Bump bin wheel version and core dependency pin to 1.12.28 |
| pom.xml | Bump Android Maven POM version to 1.12.28 |
| nodejs-examples/package.json | Bump sherpa-onnx dependency to ^1.12.28 |
| nodejs-addon-examples/package.json | Bump sherpa-onnx-node dependency to ^1.12.28 |
| new-release.sh | Update old/new versions and version codes for 1.12.28 release |
| mfc-examples/README.md | Update prebuilt EXE download URLs to v1.12.28 |
| jitpack.yml | Update AAR download/install coordinates to 1.12.28 |
| harmony-os/SherpaOnnxVadAsr/entry/oh-package.json5 | Bump Harmony dependency to 1.12.28 |
| harmony-os/SherpaOnnxVadAsr/entry/README.md | Update HAR filename reference to v1.12.28 |
| harmony-os/SherpaOnnxTts/entry/oh-package.json5 | Bump Harmony dependency to 1.12.28 |
| harmony-os/SherpaOnnxStreamingAsr/entry/oh-package.json5 | Bump Harmony dependency to 1.12.28 |
| harmony-os/SherpaOnnxSpeakerIdentification/entry/oh-package.json5 | Bump Harmony dependency to 1.12.28 |
| harmony-os/SherpaOnnxSpeakerDiarization/entry/oh-package.json5 | Bump Harmony dependency to 1.12.28 |
| harmony-os/SherpaOnnxHar/sherpa_onnx/oh-package.json5 | Bump HAR package version to 1.12.28 |
| harmony-os/SherpaOnnxHar/sherpa_onnx/README.md | Update dependency snippet to 1.12.28 |
| harmony-os/SherpaOnnxHar/sherpa_onnx/BuildProfile.ets | Bump HAR_VERSION constant to 1.12.28 |
| flutter/sherpa_onnx_macos/macos/sherpa_onnx_macos.podspec | Bump CocoaPods spec version to 1.12.28 |
| flutter/sherpa_onnx_ios/ios/sherpa_onnx_ios.podspec | Bump CocoaPods spec version to 1.12.28 |
| flutter/sherpa_onnx/pubspec.yaml | Bump Flutter package and platform plugin constraints to 1.12.28 |
| flutter-examples/tts/pubspec.yaml | Bump example app version and sherpa_onnx constraint to 1.12.28 |
| flutter-examples/streaming_asr/pubspec.yaml | Bump example app version and sherpa_onnx constraint to 1.12.28 |
| flutter-examples/non_streaming_vad_asr/pubspec.yaml | Bump example app version and sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/vad/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/vad-with-non-streaming-asr/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/tts/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/streaming-asr/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/spoken-language-identification/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/speech-enhancement-gtcrn/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/speaker-identification/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/speaker-diarization/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/non-streaming-asr/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/keyword-spotter/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/audio-tagging/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| dart-api-examples/add-punctuations/pubspec.yaml | Bump sherpa_onnx constraint to 1.12.28 |
| build-ios-shared.sh | Bump iOS framework version string to 1.12.28 |
| android/SherpaOnnxWebSocket/app/build.gradle | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxVadAsr/app/build.gradle | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxVad/app/build.gradle | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxTtsEngine/app/build.gradle.kts | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxTts/app/build.gradle | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxSpokenLanguageIdentification/app/build.gradle.kts | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxSpeakerIdentification/app/build.gradle.kts | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxSpeakerDiarization/app/build.gradle.kts | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxSimulateStreamingAsrWearOs/app/build.gradle.kts | Bump app version and sherpa-onnx dependency to v1.12.28 |
| android/SherpaOnnxSimulateStreamingAsr/app/build.gradle.kts | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxKws/app/build.gradle | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxJavaDemo/app/build.gradle | Bump app version and sherpa-onnx dependency to v1.12.28 |
| android/SherpaOnnxAudioTaggingWearOs/app/build.gradle.kts | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxAudioTagging/app/build.gradle.kts | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnxAar/README.md | Update Android tarball and output AAR naming to 1.12.28 |
| android/SherpaOnnx2Pass/app/build.gradle | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| android/SherpaOnnx/app/build.gradle | Bump Android app versionCode/versionName to 20260228 / 1.12.28 |
| CMakeLists.txt | Bump SHERPA_ONNX_VERSION to 1.12.28 |
| CHANGELOG.md | Add 1.12.28 changelog entry (Moonshine v2 additions) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores
Documentation