Skip to content

Fix CI #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csukuangfj merged 21 commits into from
Feb 16, 2026
Merged

Fix CI #3192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b195e07
Fix building wheels
csukuangfj Feb 15, 2026
06e7e97
Small fixes
csukuangfj Feb 15, 2026
d4561c3
Small fixes
csukuangfj Feb 15, 2026
5236b8f
Small fixes
csukuangfj Feb 15, 2026
452b162
Small fixes
csukuangfj Feb 15, 2026
f7bcbf3
Small fixes
csukuangfj Feb 15, 2026
8f08552
Fix npm node-addon
csukuangfj Feb 15, 2026
c0d2046
Fix npm node-addon
csukuangfj Feb 15, 2026
1a9876d
Fix npm node-addon
csukuangfj Feb 15, 2026
e7a2199
Fix npm node-addon
csukuangfj Feb 15, 2026
3632ab3
Fix npm node-addon
csukuangfj Feb 15, 2026
0a6c24d
Fix for dart
csukuangfj Feb 15, 2026
6a85165
Fix for dart
csukuangfj Feb 15, 2026
258413a
Fix npm node-addon
csukuangfj Feb 15, 2026
8613580
Fix for dart
csukuangfj Feb 15, 2026
795d115
Fix for wheel
csukuangfj Feb 15, 2026
6b73235
Fix for wheel
csukuangfj Feb 15, 2026
57a657d
Fix for gcc 10.2
csukuangfj Feb 15, 2026
c540c1f
Fix .Net
csukuangfj Feb 15, 2026
cd05e6b
Fix linux
csukuangfj Feb 15, 2026
4d108fc
Fixes after review
csukuangfj Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/aarch64-linux-gnu-shared.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,12 @@ jobs:

- name: Build sherpa-onnx
if: matrix.gpu == 'OFF'
uses: addnab/docker-run-action@v3
with:
image: quay.io/pypa/manylinux2014_aarch64
options: |
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx
shell: bash
run: |
shell: bash
run: |
docker run --rm \
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx \
quay.io/pypa/manylinux2014_aarch64 \
bash -c '
echo "config: ${{ matrix.config }}"
uname -a
which gcc
Expand Down Expand Up @@ -142,6 +141,7 @@ jobs:
rm -rf install/lib/pkgconfig
rm -fv install/lib/cargs.h
rm -fv install/lib/libcargs.so
'

- name: Display system info
shell: bash
Expand Down
16 changes: 7 additions & 9 deletions .github/workflows/aarch64-linux-gnu-static.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,12 @@ jobs:
git diff .

- name: Build sherpa-onnx
uses: addnab/docker-run-action@v3
with:
# image: quay.io/pypa/manylinux2014_aarch64 # it does not have gcc 11
image: ghcr.io/csukuangfj/manylinux2014-aarch64-gcc11:latest # i have built gcc 11 from source
options: |
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx
shell: bash
run: |
shell: bash
run: |
docker run --rm \
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx \
ghcr.io/csukuangfj/manylinux2014-aarch64-gcc11:latest \
bash -c '
echo "config: ${{ matrix.config }}"
uname -a
which gcc
Expand All @@ -58,7 +56,6 @@ jobs:

ldd --version

# ✅ FORCE GCC 11
export GCC_ROOT=/opt/gcc-11.4.0
export CC=$GCC_ROOT/bin/gcc
export CXX=$GCC_ROOT/bin/g++
Expand Down Expand Up @@ -109,6 +106,7 @@ jobs:

rm -rf install/lib/pkgconfig
rm -fv install/lib/cargs.h
'

- name: Copy files
shell: bash
Expand Down
15 changes: 7 additions & 8 deletions .github/workflows/axcl-linux-aarch64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,12 @@ jobs:
key: axcl-linux-aarch64

- name: Build sherpa-onnx
uses: addnab/docker-run-action@v3
with:
image: quay.io/pypa/manylinux_2_28_aarch64
# image: quay.io/pypa/manylinux2014_aarch64 # won't work
options: |
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx
shell: bash
run: |
shell: bash
run: |
docker run --rm \
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx \
quay.io/pypa/manylinux_2_28_aarch64 \
bash -c '
uname -a
which gcc

Expand Down Expand Up @@ -116,6 +114,7 @@ jobs:
rm -rf install/lib/pkgconfig
rm -fv install/lib/cargs.h
rm -fv install/lib/libcargs.so
'

- name: Display system info
shell: bash
Expand Down
15 changes: 7 additions & 8 deletions .github/workflows/axera-linux-aarch64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,12 @@ jobs:
key: axera-${{ matrix.soc }}-linux-aarch64

- name: Build sherpa-onnx
uses: addnab/docker-run-action@v3
with:
image: quay.io/pypa/manylinux_2_28_aarch64
# image: quay.io/pypa/manylinux2014_aarch64 # won't work
options: |
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx
shell: bash
run: |
shell: bash
run: |
docker run --rm \
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx \
quay.io/pypa/manylinux_2_28_aarch64 \
bash -c '
uname -a
which gcc

Expand Down Expand Up @@ -127,6 +125,7 @@ jobs:
rm -rf install/lib/pkgconfig
rm -fv install/lib/cargs.h
rm -fv install/lib/libcargs.so
'

- name: Display system info
shell: bash
Expand Down
17 changes: 7 additions & 10 deletions .github/workflows/build-wheels-aarch64-rknn.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,12 @@ jobs:
git clone --depth 1 https://github.com/airockchip/rknn-toolkit2

- name: Build sherpa-onnx
uses: addnab/docker-run-action@v3
with:
image: quay.io/pypa/manylinux_2_28_aarch64
# image: quay.io/pypa/manylinux2014_aarch64 # it does not provide GLIBCXX 3.4.21+
options: |
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx
shell: bash
run: |
echo "config: ${{ matrix.config }}"
shell: bash
run: |
docker run --rm \
--volume ${{ github.workspace }}/:/k2-fsa/sherpa-onnx \
quay.io/pypa/manylinux_2_28_aarch64 \
bash -c '
uname -a
which gcc

Expand Down Expand Up @@ -95,7 +92,6 @@ jobs:

cmake --version

echo "config: ${{ matrix.config }}"
uname -a
echo "pwd"

Expand Down Expand Up @@ -124,6 +120,7 @@ jobs:
python3 setup.py bdist_wheel

mv dist wheelhouse
'

- name: Display results
shell: bash
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/build-wheels-aarch64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,12 @@ jobs:
du -h -d1 .

- name: Build sherpa-onnx
uses: addnab/docker-run-action@v3
with:
image: quay.io/pypa/manylinux2014_aarch64
options: |
--volume ${{ github.workspace }}/:/home/runner/work/sherpa-onnx/sherpa-onnx
shell: bash
run: |
shell: bash
run: |
docker run --rm \
--volume ${{ github.workspace }}/:/home/runner/work/sherpa-onnx/sherpa-onnx \
quay.io/pypa/manylinux2014_aarch64 \
bash -c '
uname -a
gcc --version
cmake --version
Expand Down Expand Up @@ -110,7 +109,7 @@ jobs:
echo "----"
ls -lh install/bin

echo 'sherpa-onnx-core'
echo "sherpa-onnx-core"
mkdir -p ../scripts/wheel/sherpa-onnx-core/sherpa_onnx/lib
cp -v ./install/lib/lib*.so ../scripts/wheel/sherpa-onnx-core/sherpa_onnx/lib

Expand All @@ -124,7 +123,7 @@ jobs:

popd

echo 'sherpa-onnx-bin'
echo "sherpa-onnx-bin"

mkdir -p ../scripts/wheel/sherpa-onnx-bin/bin
cp -v ./install/bin/sherpa-onnx* ../scripts/wheel/sherpa-onnx-bin/bin
Expand All @@ -135,6 +134,7 @@ jobs:
ls -lh dist

popd
'

- name: Collect wheels
shell: bash
Expand Down
38 changes: 19 additions & 19 deletions .github/workflows/build-wheels-armv7l.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,13 @@ jobs:
du -h -d1 .

- name: Build sherpa-onnx
uses: addnab/docker-run-action@v3
with:
image: quay.io/pypa/manylinux_2_35_armv7l
options: |
--platform linux/arm/v7
--volume ${{ github.workspace }}/:/home/runner/work/sherpa-onnx/sherpa-onnx
shell: bash
run: |
shell: bash
run: |
docker run --rm \
--platform linux/arm/v7 \
--volume ${{ github.workspace }}/:/home/runner/work/sherpa-onnx/sherpa-onnx \
quay.io/pypa/manylinux_2_35_armv7l \
bash -c '
find / -name "*gcc*" 2>/dev/null

uname -a
Expand Down Expand Up @@ -124,7 +123,7 @@ jobs:

./install/bin/sherpa-onnx --help

echo 'sherpa-onnx-core'
echo "sherpa-onnx-core"
mkdir -p ../scripts/wheel/sherpa-onnx-core/sherpa_onnx/lib
cp -v ./install/lib/lib*.so ../scripts/wheel/sherpa-onnx-core/sherpa_onnx/lib

Expand All @@ -138,7 +137,7 @@ jobs:

popd

echo 'sherpa-onnx-bin'
echo "sherpa-onnx-bin"

mkdir -p ../scripts/wheel/sherpa-onnx-bin/bin
cp -v ./install/bin/sherpa-onnx* ../scripts/wheel/sherpa-onnx-bin/bin
Expand All @@ -149,6 +148,7 @@ jobs:
ls -lh dist

popd
'

- name: Collect wheels
shell: bash
Expand Down Expand Up @@ -302,14 +302,13 @@ jobs:
platforms: arm

- name: Build sherpa-onnx
uses: addnab/docker-run-action@v3
with:
image: quay.io/pypa/manylinux_2_35_armv7l
options: |
--platform linux/arm/v7
--volume ${{ github.workspace }}/:/home/runner/work/sherpa-onnx/sherpa-onnx
shell: bash
run: |
shell: bash
run: |
docker run --rm \
--platform linux/arm/v7 \
--volume ${{ github.workspace }}/:/home/runner/work/sherpa-onnx/sherpa-onnx \
quay.io/pypa/manylinux_2_35_armv7l \
bash -c '
find / -name "*gcc*" 2>/dev/null

uname -a
Expand Down Expand Up @@ -339,7 +338,7 @@ jobs:
exit 1
elif [[ ${#matches[@]} -gt 1 ]]; then
echo "Multiple Python installations found for version $python_version:"
printf ' %s\n' "${matches[@]}"
printf " %s\n" "${matches[@]}"
echo "Using the first one: ${matches[0]}"
fi

Expand Down Expand Up @@ -384,6 +383,7 @@ jobs:

mkdir wheelhouse
cp -v dist/* wheelhouse/
'

- uses: actions/upload-artifact@v4
with:
Expand Down
31 changes: 20 additions & 11 deletions .github/workflows/build-wheels-linux.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,28 +46,36 @@ jobs:
ls -lh
du -h -d1 .

- name: Build sherpa-onnx
uses: addnab/docker-run-action@v3
with:
image: quay.io/pypa/manylinux2014_x86_64
options: |
--volume ${{ github.workspace }}/:/home/runner/work/sherpa-onnx/sherpa-onnx
shell: bash
run: |
- name: Build sherpa-onnx (docker manually)
shell: bash
run: |
docker run --rm \
-v ${{ github.workspace }}:/workspace \
-w /workspace \
quay.io/pypa/manylinux2014_x86_64 \
bash -c '
uname -a
gcc --version
cmake --version
cat /etc/*release
id
pwd

cd /home/runner/work/sherpa-onnx/sherpa-onnx
cd /workspace

echo pwd
echo $PWD

find /opt -name "python*"

echo "--------------------"
PY_PATH=$(echo /opt/_internal/cpython-3.10*/bin)
echo "PY_PATH: $PY_PATH"

export PATH=$PY_PATH:$PATH

echo "path $PATH"

which python3
python3 --version

Expand Down Expand Up @@ -111,7 +119,7 @@ jobs:
echo "----"
ls -lh install/bin

echo 'sherpa-onnx-core'
echo sherpa-onnx-core

Copilot AI Feb 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing quotes around the echo argument. While functionally equivalent in this simple case, it's better practice to quote echo arguments consistently as done in line 137.

Suggested change
echo sherpa-onnx-core
echo "sherpa-onnx-core"

Copilot uses AI. Check for mistakes.
mkdir -p ../scripts/wheel/sherpa-onnx-core/sherpa_onnx/lib
cp -v ./install/lib/lib*.so ../scripts/wheel/sherpa-onnx-core/sherpa_onnx/lib

Expand All @@ -126,7 +134,7 @@ jobs:

popd

echo 'sherpa-onnx-bin'
echo "sherpa-onnx-bin"

mkdir -p ../scripts/wheel/sherpa-onnx-bin/bin
cp -v ./install/bin/sherpa-onnx* ../scripts/wheel/sherpa-onnx-bin/bin
Expand All @@ -138,6 +146,7 @@ jobs:
unzip -l dist/*.whl

popd
'

- name: Collect wheels
shell: bash
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/linux-gpu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,12 @@ jobs:
git diff .

- name: Build sherpa-onnx
uses: addnab/docker-run-action@v3
with:
image: quay.io/pypa/manylinux_2_28_x86_64
options: |
--volume ${{ github.workspace }}/:/home/runner/work/sherpa-onnx/sherpa-onnx
shell: bash
run: |
shell: bash
run: |
docker run --rm \
--volume ${{ github.workspace }}/:/home/runner/work/sherpa-onnx/sherpa-onnx \
quay.io/pypa/manylinux_2_28_x86_64 \
bash -c '
uname -a
gcc --version
cmake --version
Expand Down Expand Up @@ -108,6 +107,7 @@ jobs:

echo "----"
ls -lh install/bin
'

- name: Display dependencies of sherpa-onnx for linux
shell: bash
Expand Down
Loading
Loading