Release v1.12.24 - #3167
Release v1.12.24#3167
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis pull request is a routine version bump from 1.12.23 to 1.12.24 across the sherpa-onnx project. It updates version strings in build configurations, package manifests, documentation links, changelog entries, and embedded version constants consistently throughout Android, Flutter, Dart, iOS, HarmonyOS, Python, and Node.js package files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @csukuangfj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This release, v1.12.24, significantly enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is for the v1.12.24 release. It primarily consists of version bumps across numerous files, including build configurations, package manifests, and documentation. The CHANGELOG.md has also been updated with a comprehensive list of changes for this release. The modifications appear to be systematically applied, likely by the new-release.sh script, and are consistent across the repository. The changes are appropriate for a release, and I found no issues.
There was a problem hiding this comment.
Pull request overview
Release bump to v1.12.24, updating version references across the C++ core, Python wheels, Android/Flutter/Dart examples, Node examples, HarmonyOS packages, and release metadata.
Changes:
- Bump version strings from 1.12.23 → 1.12.24 across build/packaging manifests (CMake, Python, Maven, Gradle, Podspec, pubspec, npm, ohpm).
- Update Android
versionCodeto 20260210 and refresh git date/sha inversion.cc. - Add CHANGELOG entry for
1.12.24and update a README link target for the Flutter streaming ASR APK section.
Reviewed changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sherpa-onnx/csrc/version.cc | Updates embedded git date/sha and library version string to 1.12.24. |
| setup.py | Pins split-package dependency to sherpa-onnx-core==1.12.24. |
| scripts/wheel/sherpa-onnx-core/setup.py | Bumps sherpa-onnx-core wheel version to 1.12.24. |
| scripts/wheel/sherpa-onnx-bin/setup.py | Bumps sherpa-onnx-bin wheel version and core dependency to 1.12.24. |
| pom.xml | Bumps Android Maven artifact version to 1.12.24. |
| nodejs-examples/package.json | Updates example dependency to sherpa-onnx ^1.12.24. |
| nodejs-addon-examples/package.json | Updates example dependency to sherpa-onnx-node ^1.12.24. |
| new-release.sh | Advances old/new version + versionCode pair for the release script. |
| mfc-examples/README.md | Updates pre-built EXE download URLs to v1.12.24. |
| jitpack.yml | Updates downloaded AAR and installed Maven version to 1.12.24. |
| harmony-os/SherpaOnnxVadAsr/entry/oh-package.json5 | Bumps HarmonyOS dependency version to 1.12.24. |
| harmony-os/SherpaOnnxVadAsr/entry/README.md | Updates referenced HAR filename to v1.12.24. |
| harmony-os/SherpaOnnxTts/entry/oh-package.json5 | Bumps HarmonyOS dependency version to 1.12.24. |
| harmony-os/SherpaOnnxStreamingAsr/entry/oh-package.json5 | Bumps HarmonyOS dependency version to 1.12.24. |
| harmony-os/SherpaOnnxSpeakerIdentification/entry/oh-package.json5 | Bumps HarmonyOS dependency version to 1.12.24. |
| harmony-os/SherpaOnnxSpeakerDiarization/entry/oh-package.json5 | Bumps HarmonyOS dependency version to 1.12.24. |
| harmony-os/SherpaOnnxHar/sherpa_onnx/oh-package.json5 | Bumps HAR package version to 1.12.24. |
| harmony-os/SherpaOnnxHar/sherpa_onnx/README.md | Updates dependency snippet to 1.12.24. |
| harmony-os/SherpaOnnxHar/sherpa_onnx/BuildProfile.ets | Updates HAR_VERSION constant to 1.12.24. |
| flutter/sherpa_onnx_macos/macos/sherpa_onnx_macos.podspec | Bumps CocoaPods spec version to 1.12.24. |
| flutter/sherpa_onnx_ios/ios/sherpa_onnx_ios.podspec | Bumps CocoaPods spec version to 1.12.24. |
| flutter/sherpa_onnx/pubspec.yaml | Bumps Flutter plugin + platform package dependency versions to 1.12.24. |
| flutter-examples/tts/pubspec.yaml | Bumps example app version + sherpa_onnx dependency to 1.12.24. |
| flutter-examples/streaming_asr/pubspec.yaml | Bumps example app version + sherpa_onnx dependency to 1.12.24. |
| flutter-examples/non_streaming_vad_asr/pubspec.yaml | Bumps example app version + sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/vad/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/vad-with-non-streaming-asr/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/tts/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/streaming-asr/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/spoken-language-identification/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/speech-enhancement-gtcrn/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/speaker-identification/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/speaker-diarization/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/non-streaming-asr/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/keyword-spotter/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/audio-tagging/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| dart-api-examples/add-punctuations/pubspec.yaml | Bumps sherpa_onnx dependency to 1.12.24. |
| build-ios-shared.sh | Updates iOS framework short version string to 1.12.24. |
| android/SherpaOnnxWebSocket/app/build.gradle | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxVadAsr/app/build.gradle | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxVad/app/build.gradle | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxTtsEngine/app/build.gradle.kts | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxTts/app/build.gradle | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxSpokenLanguageIdentification/app/build.gradle.kts | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxSpeakerIdentification/app/build.gradle.kts | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxSpeakerDiarization/app/build.gradle.kts | Bumps Android app versionCode/versionName and updates Maven dependency tag to v1.12.24. |
| android/SherpaOnnxSimulateStreamingAsrWearOs/app/build.gradle.kts | Bumps Android app versionCode/versionName and updates Maven dependency tag to v1.12.24. |
| android/SherpaOnnxSimulateStreamingAsr/app/build.gradle.kts | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxKws/app/build.gradle | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxJavaDemo/app/build.gradle | Bumps Android app versionCode/versionName and updates Maven dependency tag to v1.12.24. |
| android/SherpaOnnxAudioTaggingWearOs/app/build.gradle.kts | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxAudioTagging/app/build.gradle.kts | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnxAar/README.md | Updates Android tarball/AAR filenames to v1.12.24. |
| android/SherpaOnnx2Pass/app/build.gradle | Bumps Android app versionCode/versionName to the new release. |
| android/SherpaOnnx/app/build.gradle | Bumps Android app versionCode/versionName to the new release. |
| README.md | Updates Flutter streaming ASR pre-built app link references. |
| CMakeLists.txt | Updates canonical SHERPA_ONNX_VERSION to 1.12.24. |
| CHANGELOG.md | Adds release notes section for 1.12.24. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [apk-flutter-streaming-asr]: https://k2-fsa.github.io/sherpa/onnx/flutter/asr/app.html | ||
| [apk-flutter-streaming-asr-cn]: https://k2-fsa.github.io/sherpa/onnx/flutter/asr/app-cn.html | ||
| [apk-flutter-streaming-asr]: https://k2-fsa.github.io/sherpa/onnx/flutter/pre-built-app.html#streaming-speech-recognition-stt-asr | ||
| [apk-flutter-streaming-asr-cn]: https://k2-fsa.github.io/sherpa/onnx/flutter/pre-built-app.html#streaming-speech-recognition-stt-asr |
There was a problem hiding this comment.
apk-flutter-streaming-asr-cn now points to the exact same URL as apk-flutter-streaming-asr. If there is no separate CN page anymore, consider removing/renaming the -cn reference (and/or updating the table label) to avoid implying a different Chinese-specific link; otherwise, point it at the intended CN URL.
| [apk-flutter-streaming-asr-cn]: https://k2-fsa.github.io/sherpa/onnx/flutter/pre-built-app.html#streaming-speech-recognition-stt-asr | |
| [apk-flutter-streaming-asr-cn]: https://k2-fsa.github.io/sherpa/onnx/flutter/pre-built-app-cn.html#streaming-speech-recognition-stt-asr |
Summary by CodeRabbit
Release Notes - Version 1.12.24
New Features
Bug Fixes
Improvements