Update wav files for FunASR Nano

[csukuangfj]

Summary by CodeRabbit

• Chores
  • Updated CI/CD workflow configuration to enable publishing pipelines.
  • Added new audio samples to the repository.
  • Updated build configuration for macOS compatibility.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updates the upload-models workflow by switching branches, enabling previously disabled steps for model collection and publishing, and adding new audio sample downloads. Also updates the onnxruntime SHA256 hash for macOS universal builds.

Changes

Cohort / File(s)	Summary
CI/CD Workflow Modifications .github/workflows/upload-models.yaml	Switches workflow branch reference to upload-models-2; enables tmate debugging, FunASR Nano collection, HuggingFace publishing, and ModelScope publishing steps by changing conditions from false to true; adds downloads for additional English lyrics audio samples (lyrics_en_1.wav and lyrics_en_3.wav) from multiple sources; updates README and sample-table references to include new audio entries.
CMake Build Configuration cmake/onnxruntime-osx-universal-static.cmake	Updates onnxruntime SHA256 hash value for macOS universal static builds from 00816fda... to 9ea206a6....

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

• Fix test wav files in FunASR Nano models. #3004: Modifies upload-models.yaml to update model collection and WAV handling with ffmpeg-based normalization, similar scope of workflow updates.
• Upload FunASR Nano ASR models with LLM #3003: Updates upload-models.yaml for FunASR Nano collection and publishing logic, directly overlapping with the workflow modifications in this PR.

Poem

🐰 The workflows spring alive with cheer,
Steps enabled, bright and clear,
New audio samples hop on through,
Hashes updated, fresh and new,
With every enable, pipelines run true! 🚀

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9ff170 and 3a3a64b.

📒 Files selected for processing (2)

• .github/workflows/upload-models.yaml
• cmake/onnxruntime-osx-universal-static.cmake

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @csukuangfj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the SHA256 checksum for the ONNX Runtime static library used in macOS builds. This change is crucial for maintaining the integrity and security of the build process by ensuring that the downloaded library matches the expected content. It's worth noting that the pull request title, "Update wav files for FunASR Nano," appears to be a mismatch with the actual changes implemented in the patch.

Highlights

• ONNX Runtime Checksum Update: The SHA256 checksum for the onnxruntime-osx-universal2-static_lib-1.23.2.zip file, used in macOS builds, has been updated. This ensures the integrity verification of the downloaded ONNX Runtime library.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/upload-models.yaml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the SHA256 hash for the onnxruntime dependency for macOS universal static builds. A significant issue is that the pull request title, 'Update wav files for FunASR Nano', is misleading and does not describe the actual changes. For better project history and clarity, please update the title to something more descriptive, such as 'Fix: Update onnxruntime hash for osx-universal-static'. I have also left one comment regarding code maintainability.

[gemini-code-assist]

To improve maintainability and simplify future dependency updates, it would be beneficial to define the onnxruntime version as a variable. This variable could then be used to construct the URLs and filenames, avoiding repetition and reducing the chance of errors during version bumps.

For example:

set(ONNXRUNTIME_VERSION "1.23.2")
set(onnxruntime_URL  "https://github.com/csukuangfj/onnxruntime-libs/releases/download/v${ONNXRUNTIME_VERSION}/onnxruntime-osx-universal2-static_lib-${ONNXRUNTIME_VERSION}.zip")
set(onnxruntime_URL2  "https://hf-mirror.com/csukuangfj/onnxruntime-libs/resolve/main/${ONNXRUNTIME_VERSION}/onnxruntime-osx-universal2-static_lib-${ONNXRUNTIME_VERSION}.zip")
set(onnxruntime_HASH "SHA256=9ea206a621d6e5550ddb9de0b96c4f666b074620f5c685b0479b5fa02c0bba76")

This approach could also be consistently applied to other similar files like onnxruntime-osx-arm64-static.cmake and onnxruntime-osx-x86_64-static.cmake.