Update README to include NPU support - #2830
Conversation
Summary of ChangesHello @csukuangfj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's documentation by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Caution Review failedThe pull request is closed. WalkthroughREADME.md receives a new "Supported NPUs" documentation section featuring a three-column table with RKNN, QNN, and Ascend NPUs marked with check marks, accompanied by three new reference links to corresponding documentation resources. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the README file to include a new section on supported NPUs, listing Rockchip, Qualcomm, and Ascend NPUs. The change is straightforward and improves the documentation. I've suggested a minor formatting improvement to the new table for better readability in the raw markdown source.
| | [1. Rockchip NPU (RKNN)][rknpu-doc] | [2. Qualcomm NPU (QNN)][qnn-doc] | [3. Ascend NPU][ascend-doc] | | ||
| |-------------------------------------|-----------------------------------|-----------------------------| | ||
| | ✔️ | ✔️ | ✔️ | |
There was a problem hiding this comment.
The formatting of this table is a bit inconsistent, making it harder to read in its raw markdown form. I suggest cleaning up the spacing, removing unnecessary spaces in the header, and adding alignment markers to improve readability and maintainability.
| | [1. Rockchip NPU (RKNN)][rknpu-doc] | [2. Qualcomm NPU (QNN)][qnn-doc] | [3. Ascend NPU][ascend-doc] | | |
| |-------------------------------------|-----------------------------------|-----------------------------| | |
| | ✔️ | ✔️ | ✔️ | | |
| | [1. Rockchip NPU (RKNN)][rknpu-doc] | [2. Qualcomm NPU (QNN)][qnn-doc] | [3. Ascend NPU][ascend-doc] | | |
| |:-----------------------------------:|:--------------------------------:|:---------------------------:| | |
| | ✔️ | ✔️ | ✔️ | |
Summary by CodeRabbit
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.