Repository navigation
Fix warnings for initializing tts lexicon. - #2823
Conversation
dosubot
Bot
added
the
size:XS
|
Caution Review failedThe pull request is closed. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughDuring lexicon loading in InitLexicon, lines that are empty or contain only whitespace are now skipped early with a continue, so such lines are ignored without other logic changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @csukuangfj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the robustness of the TTS lexicon initialization process by eliminating a recurring warning. The change ensures that the lexicon parser correctly handles and ignores empty or whitespace-only lines, leading to cleaner log output and more reliable lexicon loading. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a warning that occurs when processing empty lines in a lexicon file. The fix involves adding a check to skip lines that are empty or contain only whitespace. This is a good approach. I've added one suggestion to make the whitespace check more robust by including all standard whitespace characters, which will prevent potential issues with files from different operating systems (e.g., Windows line endings).
| if (line.find_first_not_of(" \t") == std::string::npos) { | ||
| // Line is empty or only spaces/tabs, skip it | ||
| continue; | ||
| } |
There was a problem hiding this comment.
The check for whitespace lines is a good addition to prevent warnings with empty or whitespace-only lines. However, it only considers spaces and tabs. It would be more robust to check for all standard whitespace characters, including carriage return (\r), which can be present in files with Windows-style line endings (\r\n).
if (line.find_first_not_of(" \t\n\v\f\r") == std::string::npos) {
// Line is empty or contains only whitespace, skip it
continue;
}![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
sherpa-onnx/csrc/character-lexicon.cc (1)
269-272: LGTM! This correctly fixes the reported warnings.The early continue for whitespace-only lines prevents the "Empty token ids for ''" warnings by skipping lines that have no actual content before they're processed. The logic is sound and the implementation is clean.
Optional: Consider including
\rin the whitespace check for cross-platform robustness.While the current fix addresses the reported issue, Windows-style line endings might leave
\rcharacters in the string. You could enhance robustness by checking for carriage returns as well:- if (line.find_first_not_of(" \t") == std::string::npos) { - // Line is empty or only spaces/tabs, skip it + if (line.find_first_not_of(" \t\r") == std::string::npos) { + // Line is empty or only whitespace, skip it continue; }This is a minor refinement and not strictly necessary for the stated problem.
1 participant
To fix the following warnings
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.