Skip to content

Export models for CANN 8.2 - #2745

Merged
csukuangfj merged 1 commit into
k2-fsa:masterfrom
csukuangfj:cann-8.2
Nov 4, 2025
Merged

csukuangfj merged 1 commit into
k2-fsa:masterfrom
csukuangfj:cann-8.2

Conversation

@csukuangfj

@csukuangfj csukuangfj commented Nov 4, 2025 •

Copy link
Copy Markdown
Collaborator

See also #2744 (comment)

Summary by CodeRabbit

  • Chores
    • Enhanced model export workflows for Ascend NPU deployments by adding CANN version matrix support.
    • Updated artifact naming and paths to include CANN version information for improved organization and traceability across Paraformer and Sense Voice export pipelines for Ascend 310P3, 910B, and 910B2 configurations.

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 4, 2025
@coderabbitai

coderabbitai Bot commented Nov 4, 2025 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Two GitHub Actions workflows for Ascend NPU model exports introduce a new cann matrix variable. The variable is threaded through job naming, environment configuration, step definitions, artifact paths, and ATC command invocations across FunASR and WSChuan-ASR/WSYue-ASR branches for multiple Ascend hardware configurations.

Changes

Cohort / File(s) Change Summary
Ascend NPU Export Workflows
.github/workflows/export-paraformer-to-ascend-npu.yaml, .github/workflows/export-sense-voice-to-ascend-npu.yaml
Added cann matrix field across all soc_version configurations. Updated job name templates to include ${{ matrix.cann }}. Propagated cann through environment variables and step definitions. Updated artifact and result directory naming to incorporate cann identifier (e.g., cann-${cann}-paraformer-zh-...). Threaded cann into ATC command invocations across all hardware branches (910B, 910B2, 310P3).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Both workflows follow the same consistent parametrization pattern for introducing the cann matrix variable
  • Changes are repetitive across multiple steps and path constructions rather than heterogeneous logic modifications
  • Primary focus should be verifying that cann is correctly threaded through all critical paths (artifact naming, environment variable exposure, ATC command construction)

Possibly related PRs

Poem

🐰 A rabbit hops through workflows bright,
With CANN versions in matrix light,
Each export thread, a careful weave,
Through paths and names we now retrieve! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db56d8b and 83a67e4.

📒 Files selected for processing (2)
  • .github/workflows/export-paraformer-to-ascend-npu.yaml (6 hunks)
  • .github/workflows/export-sense-voice-to-ascend-npu.yaml (6 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@csukuangfj
csukuangfj merged commit c385ca9 into k2-fsa:master Nov 4, 2025
1 of 2 checks passed
@csukuangfj
csukuangfj deleted the cann-8.2 branch November 4, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant