Skip to content

修复一个编译错误 - #2731

Merged
csukuangfj merged 1 commit into
k2-fsa:masterfrom
cwp-wind:master
Oct 29, 2025
Merged

csukuangfj merged 1 commit into
k2-fsa:masterfrom
cwp-wind:master

Conversation

@cwp-wind

@cwp-wind cwp-wind commented Oct 29, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Internal code maintenance update with no impact to end-user functionality or features.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 29, 2025
@coderabbitai

coderabbitai Bot commented Oct 29, 2025 •

Copy link
Copy Markdown

Walkthrough

Added <array> include directive to the offline Sense Voice Ascend model implementation file to enable std::array usage. No behavioral, control-flow, or public API changes.

Changes

Cohort / File(s) Change Summary
Standard Library Include
sherpa-onnx/csrc/ascend/offline-sense-voice-model-ascend.cc
Added #include <array> directive to enable std::array functionality

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A header so small, yet perfectly right,
<array> included, the build burns bright,
One line of code, so clean and so neat,
Makes Ascend model compilation complete! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "修复一个编译错误" (translates to "Fix a compilation error") directly and accurately describes the main change in the pull request. The changeset adds an include directive for <array> to resolve a compilation error in a single file. The title is concise, clear, and specific enough for teammates to understand the purpose of the change without being vague or misleading. It appropriately summarizes the primary intent of the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8aef0c7 and 3a09feb.

📒 Files selected for processing (1)
  • sherpa-onnx/csrc/ascend/offline-sense-voice-model-ascend.cc (1 hunks)
🔇 Additional comments (1)
sherpa-onnx/csrc/ascend/offline-sense-voice-model-ascend.cc (1)

12-12: Correct fix for missing include.

Adding <array> enables the std::array usage at lines 65, 80, and 85. The include is properly positioned after other standard library headers and before project-specific includes.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@csukuangfj csukuangfj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@csukuangfj
csukuangfj merged commit a0f335c into k2-fsa:master Oct 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants