Add license info about tts models from OpenVoiceOS - #2530
Conversation
|
Caution Review failedThe pull request is closed. Walkthroughget_en_models() now returns the concatenation of en_GB and en_US models. Many language README entries now include a standardized license block referencing Sherpa-ONNX PR 2480 and CC BY‑NC‑SA 4.0; one spot uses "README" instead of "README.md". No public API signatures changed. Changes
Sequence Diagram(s)sequenceDiagram
actor Caller
participant Gen as scripts/piper/generate.py
participant EN_US as en_US list
participant EN_GB as en_GB list
Caller->>Gen: get_en_models()
Gen->>EN_US: retrieve en_US models
Gen->>EN_GB: retrieve en_GB models
Gen->>Gen: concatenate en_GB + en_US
Gen-->>Caller: return combined English models
sequenceDiagram
actor Generator
participant Gen as scripts/piper/generate.py
participant Writer as README builder
Generator->>Gen: build language entries
loop for each language section
Gen->>Writer: write model metadata
Note right of Writer: Append license block:\n• License header\n• Link to PR #2480\n• CC BY‑NC‑SA 4.0 note\n• Usage bullets\n• Redistribution requirement
end
Gen-->>Generator: completed README content
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
dosubot
Bot
added
the
size:L
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
scripts/piper/generate.py(14 hunks)
🔇 Additional comments (15)
scripts/piper/generate.py (15)
266-272: License information added consistently across models.The standardized CC BY-NC-SA 4.0 license blocks are being correctly added to the OpenVoiceOS model READMEs with proper formatting and clear usage guidelines.
427-433: License information added consistently.The license block follows the same format as other models with proper CC BY-NC-SA 4.0 licensing information.
579-585: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
608-614: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
849-855: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
878-884: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
1079-1085: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
1108-1114: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
1140-1146: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
1169-1175: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
1637-1643: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
1666-1672: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
1718-1724: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
1748-1748: English model expansion implemented correctly.The function now returns a combination of both
en_GBanden_USmodels, expanding the available English model set as intended.
1875-1881: License information added consistently.The license block follows the same format with proper CC BY-NC-SA 4.0 licensing information.
1 participant
See also #2480
CC @JarbasAl
Summary by CodeRabbit
New Features
Documentation