Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoder only trt ep for transducer #1130

Merged
merged 3 commits into from
Jul 15, 2024
Merged

encoder only trt ep for transducer #1130

merged 3 commits into from
Jul 15, 2024

Conversation

manickavela29
Copy link
Contributor

Enabling only encoder model to run in TRT,
with decoder and joiner running in CUDA

cc : #1098

@manickavela29 manickavela29 marked this pull request as draft July 15, 2024 01:12
@manickavela29 manickavela29 changed the title WIP Transducer : encoder only trt encoder only trt ep for transducer Jul 15, 2024
@manickavela29 manickavela29 marked this pull request as ready for review July 15, 2024 01:33
csukuangfj
csukuangfj reviewed Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@csukuangfj csukuangfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left some minor comments. Otherwise, it looks good to me.

sherpa-onnx/csrc/session.cc Outdated Show resolved Hide resolved
sherpa-onnx/csrc/online-zipformer2-transducer-model.cc Outdated Show resolved Hide resolved
sherpa-onnx/csrc/online-zipformer2-transducer-model.cc Outdated Show resolved Hide resolved
manickavela29
manickavela29 commented Jul 15, 2024
View reviewed changes
Copy link
Contributor Author

@manickavela29 manickavela29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated with suggestions

csukuangfj
csukuangfj approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@csukuangfj csukuangfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@csukuangfj csukuangfj merged commit 11cfd33 into k2-fsa:master Jul 15, 2024
0 of 184 checks passed
@manickavela29 manickavela29 deleted the zip_trt_config branch July 15, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csukuangfj csukuangfj csukuangfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manickavela29 @csukuangfj