Skip to content

Conversation

@twz123
Copy link
Member

@twz123 twz123 commented Oct 30, 2025

Description

Clarify backend selection, mention that Oracle Linux uses firewalld, and reuse the ostests firewalld service snippets, so the documented setup stays in lockstep with the automated tests.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Clarify backend selection, mention that Oracle Linux uses firewalld, and
reuse the ostests firewalld service snippets, so the documented setup
stays in lockstep with the automated tests.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added documentation Improvements or additions to documentation area/network labels Oct 30, 2025
ports:
protocols:
forward: no
forward: yes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the output from Oracle Linux 9. Not sure if this is something to keep or not to keep 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we can keep it, it's just some example output

@twz123 twz123 added the backport/release-1.34 PR that needs to be backported/cherrypicked to the release-1.34 branch label Oct 30, 2025
@twz123 twz123 marked this pull request as ready for review October 30, 2025 09:42
@twz123 twz123 requested review from a team as code owners October 30, 2025 09:42
@twz123 twz123 requested review from jnummelin and ncopa October 30, 2025 09:42
@twz123 twz123 merged commit 3310d8c into k0sproject:main Oct 31, 2025
10 checks passed
@twz123 twz123 deleted the firewalld-docs branch October 31, 2025 14:38
@k0s-bot
Copy link
Contributor

k0s-bot commented Oct 31, 2025

Successfully created backport PR for release-1.34:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/network backport/release-1.34 PR that needs to be backported/cherrypicked to the release-1.34 branch documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants