Skip to content

Pin nginx images to a common version #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pin nginx images to a common version #6563

wants to merge 2 commits into from
+22 −34

Conversation

@twz123
Copy link
Member

@twz123 twz123 commented Oct 30, 2025

Description

The full version is already in use elsewhere and will be kept up to date by Renovate. This PR aligns the remaining parts with the rest of the codebase.

Rename nginx to a generic "app" in the applier unit tests. No need to use a real app there, so nobody is tempted to bump unused software versions just because they can.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Oct 30, 2025
@twz123 twz123 marked this pull request as ready for review October 30, 2025 14:44
@twz123 twz123 requested review from a team as code owners October 30, 2025 14:44
@twz123 twz123 requested review from jnummelin and ncopa October 30, 2025 14:44
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

This pull request has merge conflicts that need to be resolved.

twz123 added 2 commits November 7, 2025 08:22
@twz123
Rename nginx to a generic "app" in unit tests
a4ef095 
No need to use a real app in unit tests, so nobody is tempted to bump
unused software versions just because they can.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Pin nginx images to a common version
c638253 
The full version is already in use elsewhere and will be kept up to date
by Renovate. This commit aligns the remaining parts with the rest of
the codebase.

Signed-off-by: Tom Wieczorek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@jnummelin jnummelin Awaiting requested review from jnummelin jnummelin is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@twz123