Skip to content

Conversation

@twz123
Copy link
Member

@twz123 twz123 commented Oct 2, 2025

Description

Return an error instead of logging warnings internally. This renders the decision what to do with about a failed attempt to stop the Supervisor to the caller.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Oct 2, 2025
@twz123 twz123 force-pushed the supervisor-stop-errors branch 2 times, most recently from 4d77570 to 005a7a8 Compare October 23, 2025 16:39
Return an error instead of logging warnings internally. This renders the
decision what to do with about a failed attempt to stop the Supervisor
to the caller.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the supervisor-stop-errors branch from 005a7a8 to a239575 Compare October 23, 2025 20:13
@twz123 twz123 marked this pull request as ready for review October 26, 2025 10:52
@twz123 twz123 requested review from a team as code owners October 26, 2025 10:52
@twz123 twz123 requested review from kke and makhov October 26, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant