Skip to content

Conversation

@twz123
Copy link
Member

@twz123 twz123 commented Sep 23, 2025

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Copy link
Member Author

twz123 commented Sep 23, 2025

@twz123 twz123 marked this pull request as ready for review September 23, 2025 13:13
@twz123 twz123 requested review from a team as code owners September 23, 2025 13:13
@twz123 twz123 requested review from jnummelin and kke September 23, 2025 13:13
"description": "Group all Kubernetes updates",
"enabled": true,
"matchPackageNames": [
"k8s.io/api",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how both 0.X.Y and 1.X.Y work, but if it gets the job done it's welcome

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Renovate's point of view, these are different dependencies. The k8s.io/* dependencies from the go datasource have the version 0.xx, the k8s.io/kubernetes dependency has 1.xx. So Renovate will simply bump all of them to the newest version. This only works out because Kubernetes releases everything together at the same time. One disadvantage is that the PR title won't contain the Kubernrnetes version number, as Renovate will only include a version number in the title if it's unambiguous, but we have two.

I'm still investigating. I noticed this afternoon that some bits are still missing.

@twz123 twz123 marked this pull request as draft September 25, 2025 15:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

This pull request has merge conflicts that need to be resolved.

@github-actions
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants