Skip to content

Use a global context that reacts to OS shutdown requests #6422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use a global context that reacts to OS shutdown requests #6422

wants to merge 2 commits into from

Conversation

@twz123
Copy link
Member

@twz123 twz123 commented Sep 23, 2025

Description

Consolidate all the places in which k0s sets up signal handlers into a single shared function k0scontext.ShutdownContext. Call this function directly in k0s's main function, and funnel the context into Cobra. Replace all the manual context setups with the reference to the global one.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Sep 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

This pull request has merge conflicts that need to be resolved.

@twz123
Use a global context that reacts to OS shutdown requests
65f92d9 
Consolidate all the places in which k0s sets up signal handlers into a
single shared function k0scontext.ShutdownContext. Call this function
directly in k0s's main function, and funnel the context into Cobra.
Replace all the manual context setups with the reference to the global
one.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added this to the 1.34 milestone Sep 23, 2025
@twz123 twz123 marked this pull request as ready for review September 23, 2025 13:24
@twz123 twz123 requested review from a team as code owners September 23, 2025 13:24
@twz123 twz123 requested review from makhov and ncopa September 23, 2025 13:24
@twz123 twz123 removed this from the 1.34 milestone Sep 23, 2025
@twz123
Copy link
Member Author

twz123 commented Sep 23, 2025

Closing in favor of #6429.

@twz123 twz123 closed this Sep 23, 2025
@twz123 twz123 deleted the shutdown-context branch September 23, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@twz123