Skip to content

Add external Etcd options to docs#3937

Merged
jnummelin merged 1 commit intok0sproject:mainfrom
jnummelin:docs/external-etcd
Jan 18, 2024
Merged

Add external Etcd options to docs#3937
jnummelin merged 1 commit intok0sproject:mainfrom
jnummelin:docs/external-etcd

Conversation

@jnummelin
Copy link
Member

Description

The implementation has been done already a while ago in #1165 but the docs never got updated to reflect that 😢

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jnummelin jnummelin added backport/release-1.26 PR that needs to be backported/cherrypicked to release-1.26 branch backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch labels Jan 16, 2024
@jnummelin jnummelin requested a review from a team as a code owner January 16, 2024 18:27
@jnummelin jnummelin requested review from makhov and twz123 January 16, 2024 18:27
@jnummelin jnummelin added documentation Improvements or additions to documentation chore labels Jan 16, 2024
twz123
twz123 previously approved these changes Jan 17, 2024
@twz123 twz123 added this to the 1.29 milestone Jan 17, 2024
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
@jnummelin
Copy link
Member Author

@twz123 fixed the suggestions, PTAL

@jnummelin jnummelin merged commit 9cee4a9 into k0sproject:main Jan 18, 2024
@k0s-bot
Copy link
Contributor

k0s-bot commented Jan 18, 2024

Successfully created backport PR for release-1.26:

@k0s-bot
Copy link
Contributor

k0s-bot commented Jan 18, 2024

Successfully created backport PR for release-1.27:

@k0s-bot
Copy link
Contributor

k0s-bot commented Jan 18, 2024

Successfully created backport PR for release-1.28:

@jnummelin jnummelin deleted the docs/external-etcd branch January 18, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/release-1.26 PR that needs to be backported/cherrypicked to release-1.26 branch backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch chore documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants