Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix- When removing all services from a cluster deployment the services remain deployed #1141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kylewuolle
Copy link
Contributor

This simple fix resolves an issue where the services aren't removed by sveltos when the services list is empty / missing in the cluster deployment after previously being deployed. The fix is to remove the sveltos profile which triggers the adon controller to un-deploy all the helm charts associated with the profile.

Testing performed:

  1. Create cluster deployment with nginx/kyverno installed
  2. Remove nginx and apply the cluster deployment yaml
  3. nginx is uninstalled as expected
  4. Remove kyverno and apply the yaml file again and now kyverno is uninstalled. Previous to this fix kyverno would have remained.

…e sveltos Profile which will trigger the addon controller to remove the installed services.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant