Implement IPAM provider and include it in vsphere cluster templates. #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewuolle
requested review from
Kshatrix,
eromanova,
a13x5 and
zerospiel
as code owners
Kshatrix
requested changes
Feb 26, 2025
| @@ -32,7 +32,8 @@ rootVolumeSize: 30 | |||
| cpus: 2 | |||
| memory: 4096 | |||
| vmTemplate: "" | |||
| network: "" | |||
| network: | |||
There was a problem hiding this comment.
the change is backwards incompatible (in case it matters already, needs to be clarified)
| @@ -1,3 +1,4 @@ | |||
| {{- $ipamEnabled := .Values.controlPlane.network.ipam }} | |||
There was a problem hiding this comment.
all params should be explicitly defined in the chart values
| @@ -140,7 +140,7 @@ | |||
| "type": "string" | |||
| }, | |||
| "network": { | |||
| "type": "string" | |||
| "type": "object" | |||
There was a problem hiding this comment.
please be specific which options are supported
| appVersion: "v1.0.0" | ||
| annotations: | ||
| cluster.x-k8s.io/provider: cluster-api-provider-ipam | ||
| cluster.x-k8s.io/v1beta1: v1beta1 |
There was a problem hiding this comment.
they don't seem to have beta version yet
| # It is recommended to use it with quotes. | ||
| appVersion: "v1.0.0" | ||
| annotations: | ||
| cluster.x-k8s.io/provider: cluster-api-provider-ipam |
There was a problem hiding this comment.
it should be ipam-in-cluster
| name: ipam | ||
| spec: | ||
| version: v1.0.0 | ||
| fetchConfig: |
There was a problem hiding this comment.
I think with you won't need fetchConfig if you have a proper name for the provider, please check
There was a problem hiding this comment.
Please update versions of the charts (Chart.yaml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves issue https://github.com/k0rdent/2a-internal/issues/7 by creating a new provider template for the CNCF cluster API IPAM provider (https://github.com/kubernetes-sigs/cluster-api-ipam-provider-in-cluster) and incorporating it into the vsphere standalone and hosted cluster templates.