Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh when Invalid Session error occurs #58

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

k-capehart
Copy link
Owner

@k-capehart k-capehart commented Aug 2, 2024

  • if an operation fails due to an invalid session, attempt to refresh the session by resubmitting credentials
  • only attempt to refresh once to avoid entering an endless loop

@k-capehart k-capehart self-assigned this Aug 2, 2024
@k-capehart k-capehart changed the title if an operation fails due to an invalid session, attempt to refresh the session by resubmitting credentials Refresh when Invalid Session error occurs Aug 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 98.00995% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.84%. Comparing base (fe7cb16) to head (79253d6).

Files Patch % Lines
auth.go 94.87% 1 Missing and 1 partial ⚠️
salesforce.go 96.61% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   86.45%   87.84%   +1.38%     
==========================================
  Files           6        6              
  Lines         997     1111     +114     
==========================================
+ Hits          862      976     +114     
  Misses         69       69              
  Partials       66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

auth.go Show resolved Hide resolved
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes. Here are a few optional suggestions

auth.go Outdated Show resolved Hide resolved
auth.go Show resolved Hide resolved
@k-capehart k-capehart merged commit 5096c4d into main Aug 5, 2024
1 check passed
@k-capehart k-capehart deleted the feature/refresh-sessions branch August 6, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants