Add requestHook to handleProxies, standardize options format#704
Merged
jycouet merged 7 commits intojycouet:mainfrom Aug 20, 2024
Merged
Add requestHook to handleProxies, standardize options format#704jycouet merged 7 commits intojycouet:mainfrom
requestHook to handleProxies, standardize options format#704jycouet merged 7 commits intojycouet:mainfrom
Conversation
…equest error handling Sveltekit uses an `instanceof` check for redirects, proper error handling, etc which breaks if `preserveSymlinks` is set
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 732605b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Contributor
Author
|
I'm not sure what happened to the build - it works locally fine - error log at https://cloud.nx.app/runs/EScVSneeIu/task/%40kitql%2Fhandles%3Abuild |
jycouet
reviewed
Aug 20, 2024
Owner
jycouet
left a comment
jycouet
left a comment
There was a problem hiding this comment.
I have no clue why it failed too! Just re run, and now it's ok.
You want to add the changeset?
Since it's pre 1.0, you can put "minor" starting with [BREAKING].
You can do this from the root pnpm changeset
Let me know
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change since the
handleProxiesarguments have changed shape. However, migration should be trivial.