-
Notifications
You must be signed in to change notification settings - Fork 17
Please port tests to Python 3 #141
Comments
@jwilk what's the rationale behind a "wontfix"? That you don't want to implement this, but would be up for pull requests, or that you don't want to see this being implemented at all? The alternative is basically having no tests (which is not great) in a distribution context soon (as all major Linux distributions drop their support short or mid term). |
Any progress on this issue? |
Given the fact that other packages like didjvu, ocrodjvu and djvusmooth, which use pure Python, share the same wontfix labels and at least for ocrodjvu there actually is an open PR without recent activity (for didjvu there is a Python 3 port as well, although no PR given the circumstances), I am going to assume that there will not really be official support for this in the near future. From my experience with porting didjvu to Python 3, most of it should be rather straightforward - especially as in the case of pdf2djvu where only the tests are affected where every line is being executed. Nevertheless, some care has to be taken to make the tests compatible with recent Python versions (starting at Python 3.10): The nose package has been deprecated for quite some time and the code requires some custom patching with Python >= 3.10. For the didjvu part, I recently replaced the whole nose stuff with plain stdlib unittest implementations, discovery and runners. |
I just gave it a try and with some trial-and-error I managed to get the existing tests to work on Python 3.8. Some notes about it:
If someone wants to address some of this stuff, feel free to check out my current fork at https://github.com/FriedrichFroebel/pdf2djvu (PRs are enabled). |
* remove temporary patch for poppler (it is fixed in upstream now) * update the patch for migrating tests to Python 3 (unfortunately, upstream doesn't seem to want migrating to Python 3 :( ) jwilk-archive/pdf2djvu#141
Please port the tests to Python 3 since Python 2 is up for retirement in a few days https://pythonclock.org/
The text was updated successfully, but these errors were encountered: