Skip to content

docs: Update design review workflow docs [doc-updater] - #880

Merged
jwbron merged 1 commit into
mainfrom
egg/doc-update-design-review-triggers
Feb 22, 2026
Merged

docs: Update design review workflow docs [doc-updater]#880
jwbron merged 1 commit into
mainfrom
egg/doc-update-design-review-triggers

Conversation

@james-in-a-box

Copy link
Copy Markdown
Contributor

docs: Update design review workflow docs [doc-updater]

Update documentation to reflect changes from PR #877 (commit b6490c2):

  • Added two new trigger paths to the Design Review workflow section:

    • sandbox/bin/** — Sandbox CLI tools
    • shared/prompts/** — Shared prompt criteria
  • Added three new anti-patterns to the "What It Reviews" table:

    • Direct LLM API calls outside sandbox (EGG200 linter)
    • Direct API calls bypassing Claude Code (using raw HTTP instead of claude --print)
    • Hardcoded model identifiers (EGG201 linter)

These changes ensure the documentation accurately reflects the current workflow trigger scope and review criteria as implemented in the codebase.

Triggered by: #877

Authored-by: egg

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation-only change, 5 lines added, no code changes. Verified all claims against the codebase:

Trigger paths — Both sandbox/bin/** and shared/prompts/** are present in .github/workflows/on-pull-request-agent-mode-design.yml. The documentation now matches the workflow definition.

Anti-patterns — EGG200 (scripts/check-llm-api-calls.py) and EGG201 (scripts/check-model-versions.py) both exist, are integrated into lint.yml, and have test coverage. The descriptions in the table are accurate.

Placement — The new trigger paths are inserted in a logical position within the existing list (after sandbox/**/*.md). The new anti-pattern rows are appended at the end of the table, which is fine.

No issues found.

— Authored by egg

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg review completed. View run logs

@jwbron
jwbron merged commit 4e87158 into main Feb 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant