docs: Add startup reconciliation to orchestrator docs [doc-updater] - #844
Conversation
Update documentation to reflect changes from commit 63051b0: - Add startup_reconciliation.py to STRUCTURE.md orchestrator file list - Document startup reconciliation behavior in orchestrator architecture The orchestrator now automatically detects and recovers pipelines with orphaned container state on restart. This prevents pipelines from being stuck in RUNNING state after a crash. Authored-by: egg
There was a problem hiding this comment.
No agent-mode design concerns.
This is a documentation-only change (STRUCTURE.md file listing + orchestrator architecture docs) reflecting an already-merged implementation. No agent workflows, prompts, or automation patterns are affected.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Documentation-only PR. Reviewed the diff against the actual orchestrator/startup_reconciliation.py implementation (added in #839).
Verification results:
STRUCTURE.md: File entry is in correct alphabetical position, file exists, description matches the module docstring. Correct.orchestrator.md: All claims in the new "Startup reconciliation" subsection are accurate:- Reconciliation targets pipelines with
status=RUNNING— matches line 84 ofstartup_reconciliation.py - Agents/containers with missing Docker container IDs are marked
FAILED— matches lines 94-123 - Pipeline itself is marked
FAILEDwith restart instructions — matches lines 125-130 - Restart via
POST /pipelines/{id}/startpreserves worktrees — confirmed inroutes/pipelines.py(worktree cleanup is skipped on restart)
- Reconciliation targets pipelines with
- The replaced line (
See orchestrator/state_store.py for implementation details.) is preserved and expanded to also referencestartup_reconciliation.py
No issues found. Placement under "Pipeline State Persistence" is appropriate since reconciliation runs at startup against persisted state.
One minor note (non-blocking): the "Startup reconciliation" subsection is nested under "Pipeline State Persistence" which is reasonable, but as more startup behaviors are added, it could warrant its own top-level section. Fine for now.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
| egg is addressing review feedback... |
|
egg feedback addressed. View run logs 2 previous review(s) hidden. |
docs: Add startup reconciliation to orchestrator docs [doc-updater]
Update documentation to reflect changes from #839 (commit 63051b0):
startup_reconciliation.pyto STRUCTURE.md orchestrator file listChanges
The orchestrator now automatically detects and recovers pipelines with orphaned container state on restart. When the orchestrator starts up, it:
status=RUNNINGFAILEDFAILEDwith instructions to restart viaPOST /pipelines/{id}/startThis prevents pipelines from being stuck in
RUNNINGstate indefinitely after an orchestrator crash.Documentation Updates
startup_reconciliation.pyto the orchestrator file listingTriggered by: #839
Authored-by: egg