Skip to content

Remove dangling setup-gateway symlink - #823

Merged
jwbron merged 1 commit into
mainfrom
egg/fix-dangling-symlink
Feb 18, 2026
Merged

Remove dangling setup-gateway symlink#823
jwbron merged 1 commit into
mainfrom
egg/fix-dangling-symlink

Conversation

@james-in-a-box

Copy link
Copy Markdown
Contributor

Remove dangling bin/setup-gateway symlink that breaks all review checks.

bin/setup-gateway is a symlink to ../gateway/setup.sh, but the
target was deleted without cleaning up the symlink. GitHub Actions
fails to resolve it during action download (Set up job step),
breaking the egg-review workflow on every PR.

Issue: none

Test plan:

  • Review checks on this PR (and subsequent PRs) should pass the
    Set up job step

Authored-by: egg

The symlink target (gateway/setup.sh) was deleted but the symlink
in bin/ was not cleaned up. This dangling symlink breaks GitHub
Actions action downloads because the runner cannot resolve it
during the Set up job step, failing all review checks.
james-in-a-box Bot pushed a commit that referenced this pull request Feb 18, 2026
@jwbron
jwbron merged commit 2fdde4f into main Feb 18, 2026
7 of 8 checks passed
jwbron pushed a commit that referenced this pull request Feb 18, 2026
* Fix feedback iteration limit never enforcing

* Exempt reviewer agents from reviews/ readonly mount

* Remove dangling setup-gateway symlink

The symlink target (gateway/setup.sh) was deleted but the symlink
in bin/ was not cleaned up. This dangling symlink breaks GitHub
Actions action downloads because the runner cannot resolve it
during the Set up job step.

* Revert dangling symlink removal (moved to PR #823)

* Skip .egg-readonly marker in reviews/ for reviewer agents

Thread agent_role through ensure_egg_state_dirs so that reviewer agents
don't get a misleading .egg-readonly marker in reviews/, since that
directory is not mounted readonly for them. Addresses review feedback
on the reviewer readonly exemption.

---------

Co-authored-by: egg <egg@localhost>
Co-authored-by: egg-reviewer[bot] <261018737+egg-reviewer[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant