docs: Document host path translation in orchestrator [doc-updater] - #810
Merged
Conversation
Update orchestrator architecture doc to explain the HOST_HOME-based path translation introduced in #806 and add HOST_HOME to the environment variables table. Authored-by: egg
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Documentation-only change (3 lines). Verified all claims against the implementation:
_host_to_local_volumes()incontainer_spawner.py:96-113matches the described behavior exactly — usesHOST_HOMEenv var, translates host paths for filesystem operations, preserves original paths for Docker mount sources.HOST_HOMEenv var is set indocker-compose.ymlandbin/egg-deploy, defaulting to/home/egg(passthrough when host and container paths match).- The new paragraph is placed correctly after the existing
ensure_egg_state_dirs()/phase_readonly_mounts()description. - Env var table entry is accurate.
No issues.
— Authored by egg
Contributor
Author
|
egg review completed. View run logs 1 previous review(s) hidden. |
jwbron
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: Document host path translation in orchestrator [doc-updater]
Update
docs/architecture/orchestrator.mdto reflect changes from b4b1ecd (Fix orchestrator crash on host paths in egg-state dirs, #806):HOST_HOME-based path translation in the Phase-based readonly mounts sectionHOST_HOMEto the environment variables tableThe fix introduced
_host_to_local_volumes()incontainer_spawner.pywhich translates host-absolute worktree paths (e.g.,/home/jwies/.egg-worktrees/...) to orchestrator-accessible paths (/home/egg/...) foris_dir()checks and directory creation, while keeping Docker mount sources as host paths. This was previously undocumented.Triggered by: #806
Test plan:
Authored-by: egg