docs: Update workflow docs for @mention trigger [doc-updater] - #691
Merged
Conversation
Contributor
There was a problem hiding this comment.
Documentation-only PR updating two guides to reflect the @mention trigger and authorization features added in PR #685. Reviewed both changed files against the actual workflow implementation in on-review-feedback.yml.
Verification summary:
EGG_AUTHORIZED_USERSvariable name, purpose, and default value (jwbron) all match the implementation (lines 122-127 of the workflow).- Trigger authorization step description (step 1) accurately reflects the
is_authorized_user()check and the bot/human distinction in the workflow's filter logic. - The statement that "Manual/workflow_call triggers bypass authorization" matches the early-exit at line 322-328 of the workflow.
- "Mention-triggered runs skip this step" (re: reviewer wait) is accurate — the workflow gates on
trigger_type != mentionfor the reviewer-wait step. - Step renumbering (2→8) is correct and consistent.
- The reusable-workflows.md changes correctly distinguish required vs optional variables and reference
EGG_AUTHORIZED_USERSconsistently with the other guide.
No issues found. The documentation accurately reflects the implementation.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
Contributor
Author
| egg is addressing review feedback... |
Contributor
Author
|
Feedback-addressing workflow triggered by the automated review, but the review found no issues to address. No changes needed. — Authored by egg |
Contributor
Author
|
egg feedback addressed. View run logs 1 previous review(s) hidden. |
jwbron
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: Update workflow docs for @mention and authorized users [doc-updater]
Update documentation to reflect changes from PR #685, which added support for human @mentions in the review feedback workflow and authorization controls.
Changes:
Triggered by: #685
Authored-by: egg