Skip to content

docs: Update workflow docs for @mention trigger [doc-updater] - #691

Merged
jwbron merged 1 commit into
mainfrom
egg/doc-update-mention-trigger
Feb 15, 2026
Merged

docs: Update workflow docs for @mention trigger [doc-updater]#691
jwbron merged 1 commit into
mainfrom
egg/doc-update-mention-trigger

Conversation

@james-in-a-box

Copy link
Copy Markdown
Contributor

docs: Update workflow docs for @mention and authorized users [doc-updater]

Update documentation to reflect changes from PR #685, which added support for human @mentions in the review feedback workflow and authorization controls.

Changes:

  • Updated Address Review Feedback workflow description to mention @mention capability
  • Added trigger authorization section explaining authorized_users configuration
  • Documented EGG_AUTHORIZED_USERS repository variable in both guides
  • Updated trigger events list to clarify bot and human triggers
  • Renumbered workflow steps after adding trigger authorization step

Triggered by: #685

Authored-by: egg

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation-only PR updating two guides to reflect the @mention trigger and authorization features added in PR #685. Reviewed both changed files against the actual workflow implementation in on-review-feedback.yml.

Verification summary:

  • EGG_AUTHORIZED_USERS variable name, purpose, and default value (jwbron) all match the implementation (lines 122-127 of the workflow).
  • Trigger authorization step description (step 1) accurately reflects the is_authorized_user() check and the bot/human distinction in the workflow's filter logic.
  • The statement that "Manual/workflow_call triggers bypass authorization" matches the early-exit at line 322-328 of the workflow.
  • "Mention-triggered runs skip this step" (re: reviewer wait) is accurate — the workflow gates on trigger_type != mention for the reviewer-wait step.
  • Step renumbering (2→8) is correct and consistent.
  • The reusable-workflows.md changes correctly distinguish required vs optional variables and reference EGG_AUTHORIZED_USERS consistently with the other guide.

No issues found. The documentation accurately reflects the implementation.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@james-in-a-box

Copy link
Copy Markdown
Contributor Author
egg is addressing review feedback...

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

Feedback-addressing workflow triggered by the automated review, but the review found no issues to address. No changes needed.

— Authored by egg

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg feedback addressed. View run logs

1 previous review(s) hidden.

@jwbron
jwbron merged commit 102b7c9 into main Feb 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant