docs: Update reviewers for multi-phase [doc-updater] - #686
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Verified the documentation changes against the actual codebase (post-PR #678 merge). The claims are accurate:
- Reviewer roles per phase: Match
_PHASE_REVIEWERSinshared/egg_contracts/agent_roles.py:649-663exactly. - Implement dependencies: Reviewers depend on INTEGRATOR — confirmed via role definitions (lines 440, 461, 493, 515) and graph builder filtering in
dependency_graph.py:build_from_roles(). - Plan dependencies: Reviewers depend on TASK_PLANNER and RISK_ANALYST — same mechanism, INTEGRATOR is filtered out since it's not in the plan role set.
- Refine behavior: Single-worker (coder only) with reviewers spawned sequentially after worker completion — confirmed at
orchestrator/routes/pipelines.py:2477-2480and2793-2815. - SDLC guide consistency:
docs/guides/sdlc-pipeline.md:226-230already has the correct phase-reviewer table. No conflict. - No stale references: The removed "only operate in the implement phase" text was the last outdated reference in the README.
One minor observation (non-blocking): line 148 says "In refine phase (single-agent), reviewers run after the coder completes." The parenthetical "(single-agent)" refers to the worker execution model (single coder vs. multi-agent waves), not the total container count for the phase. This reads correctly in context of the preceding paragraph, but could be misread as "only one agent runs in refine" when in fact 3 containers spawn (1 coder + 2 reviewers). Consider "In refine phase (single-worker)" or "In refine phase (no wave execution)" if this causes confusion in the future.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Agreed. Changed "(single-agent)" to "(single-worker)" on line 148 to clarify this refers to the worker execution model (one coder), not the total container count for the phase (which is 1 coder + 2 reviewers). Pushed in 1d10ee9. — Authored by egg |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Re-reviewed at commit 1d10ee9.
Delta since last review (8b627dd): Single commit that changes "(single-agent)" to "(single-worker)" on line 148 of README.md. This directly addresses the suggestion from the previous review.
Previous feedback status: Resolved. The wording now correctly distinguishes the worker execution model (one coder) from the total container count (1 coder + 2 reviewers).
No new issues found. The documentation accurately reflects the codebase behavior as verified in the initial review.
— Authored by egg
|
egg review completed. View run logs 4 previous review(s) hidden. |
docs: Update reviewer docs for multi-phase execution [doc-updater]
Update documentation to reflect changes from PR #678 which enabled
multi-agent reviewers across refine, plan, and implement phases.
Changes:
reviewers now run in refine, plan, and implement phases (not just
implement)
task planner + risk analyst for plan phase, and coder for refine
phase
the implement phase"
The SDLC Pipeline guide already had the correct reviewer phase table
and did not need updating.
Triggered by: #678
Authored-by: egg