Skip to content

docs: Add monitoring mention to /sdlc command description - #667

Merged
jwbron merged 2 commits into
mainfrom
egg/fix-sdlc-readme-monitoring
Feb 14, 2026
Merged

docs: Add monitoring mention to /sdlc command description#667
jwbron merged 2 commits into
mainfrom
egg/fix-sdlc-readme-monitoring

Conversation

@james-in-a-box

Copy link
Copy Markdown
Contributor

Summary

  • Re-adds monitoring mention to /sdlc command description in commands README
  • Addresses non-blocking review feedback from PR docs: Update README for egg-sdlc CLI [doc-updater] #666 (egg-reviewer noted the "Shows how to monitor progress" bullet was removed without replacement)
  • References egg-pipeline-watch as the monitoring tool, consistent with sdlc.md

Issue: none (follow-up to #666 review feedback)

Test plan:

  • Verify the /sdlc section in sandbox/.claude/commands/README.md includes the monitoring bullet
  • Confirm egg-pipeline-watch reference matches what's documented in sdlc.md

Authored-by: egg

Address review feedback from PR #666 noting that the 'Shows how to
monitor progress' bullet was removed without replacement. Add reference
to egg-pipeline-watch for monitoring pipeline progress.

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No agent-mode design concerns. This is a one-line documentation addition referencing egg-pipeline-watch for monitoring — straightforward follow-up to #666 review feedback.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-line documentation addition. Verified:

  • egg-pipeline-watch exists at sandbox/bin/egg-pipeline-watch
  • Reference is consistent with sandbox/.claude/commands/sdlc.md (line 28)
  • Correctly addresses the review feedback from #666 about the removed monitoring bullet

No issues.

Minor: the existing bullets describe what the /sdlc command does ("Provides instructions...", "handles DAG visualization..."), while the new bullet is an imperative instruction to the reader ("Use egg-pipeline-watch..."). Consider rephrasing for consistency, e.g.: - References egg-pipeline-watch for monitoring pipeline progress. Not blocking.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@james-in-a-box

This comment has been minimized.

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

Agreed. Rephrased the bullet from imperative ("Use egg-pipeline-watch...") to descriptive ("References egg-pipeline-watch...") for consistency with the other bullets in the list.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No agent-mode design concerns. The delta since last review is a single-word style fix ("Use" → "References") addressing the general review bot's feedback on bullet phrasing consistency. No agent-mode implications.

— Authored by egg

@james-in-a-box

This comment has been minimized.

@egg-reviewer egg-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of changes since a0aa8a09.

Delta: Single commit (1390171) — one word change: "Use" → "References" on line 15 of sandbox/.claude/commands/README.md.

Previous feedback addressed: The style consistency suggestion (imperative → descriptive voice) has been applied exactly as recommended. The bullet now reads "References egg-pipeline-watch for monitoring pipeline progress", matching the descriptive tone of the other bullets ("Provides instructions...", "handles DAG visualization...").

Verified:

  • egg-pipeline-watch exists at sandbox/bin/egg-pipeline-watch
  • sdlc.md line 28 references egg-pipeline-watch — the README accurately describes the command file
  • Stylistically consistent with surrounding bullets

No issues.

— Authored by egg

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg review completed. View run logs

5 previous review(s) hidden.

@jwbron
jwbron merged commit d8512a6 into main Feb 14, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant