docs: Add monitoring mention to /sdlc command description - #667
Conversation
Address review feedback from PR #666 noting that the 'Shows how to monitor progress' bullet was removed without replacement. Add reference to egg-pipeline-watch for monitoring pipeline progress.
There was a problem hiding this comment.
No agent-mode design concerns. This is a one-line documentation addition referencing egg-pipeline-watch for monitoring — straightforward follow-up to #666 review feedback.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
One-line documentation addition. Verified:
egg-pipeline-watchexists atsandbox/bin/egg-pipeline-watch- Reference is consistent with
sandbox/.claude/commands/sdlc.md(line 28) - Correctly addresses the review feedback from #666 about the removed monitoring bullet
No issues.
Minor: the existing bullets describe what the /sdlc command does ("Provides instructions...", "handles DAG visualization..."), while the new bullet is an imperative instruction to the reader ("Use egg-pipeline-watch..."). Consider rephrasing for consistency, e.g.: - References egg-pipeline-watch for monitoring pipeline progress. Not blocking.
— Authored by egg
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Agreed. Rephrased the bullet from imperative ("Use — Authored by egg |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Re-review of changes since a0aa8a09.
Delta: Single commit (1390171) — one word change: "Use" → "References" on line 15 of sandbox/.claude/commands/README.md.
Previous feedback addressed: The style consistency suggestion (imperative → descriptive voice) has been applied exactly as recommended. The bullet now reads "References egg-pipeline-watch for monitoring pipeline progress", matching the descriptive tone of the other bullets ("Provides instructions...", "handles DAG visualization...").
Verified:
egg-pipeline-watchexists atsandbox/bin/egg-pipeline-watchsdlc.mdline 28 referencesegg-pipeline-watch— the README accurately describes the command file- Stylistically consistent with surrounding bullets
No issues.
— Authored by egg
|
egg review completed. View run logs 5 previous review(s) hidden. |
Summary
/sdlccommand description in commands READMEegg-pipeline-watchas the monitoring tool, consistent withsdlc.mdIssue: none (follow-up to #666 review feedback)
Test plan:
/sdlcsection insandbox/.claude/commands/README.mdincludes the monitoring bulletegg-pipeline-watchreference matches what's documented insdlc.mdAuthored-by: egg