docs: Remove hardcoded bot username [doc-updater] - #473
Conversation
Update @mention workflow documentation to remove reference to the old hardcoded bot username 'james-in-a-box'. This aligns with PR #469 which removed all hardcoded bot usernames and replaced them with the configurable BOT_USERNAME variable. Authored-by: egg
There was a problem hiding this comment.
No issues found.
This is a straightforward documentation fix that removes a missed @james-in-a-box reference from the @mention workflow documentation. The change is consistent with PR #469's goal of replacing hardcoded bot usernames with the configurable BOT_USERNAME variable.
Verified that:
- Line 218 now correctly references only
@egg, matching line 17's overview table - The change aligns with the existing documentation pattern throughout the file
— Authored by egg
|
egg review completed. View run logs |
|
@james-in-a-box we don't want to support tagging at-egg any longer. Let's remove that reference and just say "the configured bot". Also ensure we're not still supporting tagging @ egg any longer |
|
Done. I've made the following changes: Documentation (
Workflow (
The workflow will no longer respond to — Authored by egg |
|
egg finished successfully but did not post a response. View run logs |
There was a problem hiding this comment.
Agent-mode design review: No concerns
This PR changes default mention patterns in the on-mention workflow configuration — it's purely about when the workflow triggers, not how the agent operates. No pre-fetching, structured output requirements, post-processing pipelines, or other agent-mode anti-patterns involved.
(Unable to formally approve as this PR was authored by the same GitHub App identity.)
— Authored by egg
|
egg agent-mode-design completed. View run logs |
There was a problem hiding this comment.
Approved. Changes correctly address the previous feedback.
Verification
The owner requested:
- Remove support for tagging
@egg→ ✓ Removed frommention_patternsdefault (lines 42, 83) - Say "the configured bot" instead of
@egg→ ✓ Documentation updated (lines 17, 218)
Changes Reviewed
Workflow (on-mention.yml):
mention_patternsdescription example:@mybot,@egg→@mybot- Default value:
@james-in-a-box,@egg→@james-in-a-box - Fallback in resolve-inputs job: same change
Documentation (github-automation.md):
- Overview table:
`@egg` in issues/PR comments→Bot mention in issues/PR comments - Section text:
mentions @egg or @james-in-a-box→mentions the configured bot
All changes are consistent and complete. The workflow will no longer respond to @egg mentions by default, and the documentation now correctly describes the behavior as depending on the configured mention_patterns input rather than hardcoded names.
— Authored by egg
|
egg review completed. View run logs |
Update documentation to remove hardcoded bot username reference that was missed in PR #469.
PR #469 replaced hardcoded bot usernames across workflows, code, and most documentation with the configurable
BOT_USERNAMEvariable. However, one reference to the old bot username remained in the GitHub automation guide.This PR removes the outdated
@james-in-a-boxreference from the @mention workflow documentation, ensuring all docs consistently reference only the generic@eggmention pattern.Triggered by: f36d02a
Authored-by: egg