Skip to content

docs: Remove hardcoded bot username [doc-updater] - #473

Merged
jwbron merged 2 commits into
mainfrom
egg/doc-update-bot-username
Feb 10, 2026
Merged

docs: Remove hardcoded bot username [doc-updater]#473
jwbron merged 2 commits into
mainfrom
egg/doc-update-bot-username

Conversation

@james-in-a-box

Copy link
Copy Markdown
Contributor

Update documentation to remove hardcoded bot username reference that was missed in PR #469.

PR #469 replaced hardcoded bot usernames across workflows, code, and most documentation with the configurable BOT_USERNAME variable. However, one reference to the old bot username remained in the GitHub automation guide.

This PR removes the outdated @james-in-a-box reference from the @mention workflow documentation, ensuring all docs consistently reference only the generic @egg mention pattern.

Triggered by: f36d02a

Authored-by: egg

Update @mention workflow documentation to remove reference to the old
hardcoded bot username 'james-in-a-box'. This aligns with PR #469 which
removed all hardcoded bot usernames and replaced them with the configurable
BOT_USERNAME variable.

Authored-by: egg

@james-in-a-box james-in-a-box Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

This is a straightforward documentation fix that removes a missed @james-in-a-box reference from the @mention workflow documentation. The change is consistent with PR #469's goal of replacing hardcoded bot usernames with the configurable BOT_USERNAME variable.

Verified that:

  • Line 218 now correctly references only @egg, matching line 17's overview table
  • The change aligns with the existing documentation pattern throughout the file

— Authored by egg

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg review completed. View run logs

@jwbron

jwbron commented Feb 10, 2026

Copy link
Copy Markdown
Owner

@james-in-a-box we don't want to support tagging at-egg any longer. Let's remove that reference and just say "the configured bot".

Also ensure we're not still supporting tagging @ egg any longer

- Update on-mention.yml to remove @Egg from default mention_patterns
- Update github-automation.md to reference "the configured bot" instead of @Egg
- Per request in #473 to stop supporting @Egg tagging

Authored-by: egg
@james-in-a-box

Copy link
Copy Markdown
Contributor Author

Done. I've made the following changes:

Documentation (docs/guides/github-automation.md):

  • Changed the workflows table to say "Bot mention" instead of `@egg`
  • Changed "@mention Response" section to say "the configured bot" instead of `@egg`

Workflow (on-mention.yml):

  • Removed @egg from the default mention_patterns (was @james-in-a-box,@egg, now just @james-in-a-box)
  • Updated the example in the description to remove @egg reference

The workflow will no longer respond to @egg mentions by default. Repos that want to respond to specific mentions can configure the mention_patterns input when calling the workflow.

— Authored by egg

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg finished successfully but did not post a response. View run logs

@james-in-a-box james-in-a-box Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent-mode design review: No concerns

This PR changes default mention patterns in the on-mention workflow configuration — it's purely about when the workflow triggers, not how the agent operates. No pre-fetching, structured output requirements, post-processing pipelines, or other agent-mode anti-patterns involved.

(Unable to formally approve as this PR was authored by the same GitHub App identity.)

— Authored by egg

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg agent-mode-design completed. View run logs

@james-in-a-box james-in-a-box Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Changes correctly address the previous feedback.

Verification

The owner requested:

  1. Remove support for tagging @egg → ✓ Removed from mention_patterns default (lines 42, 83)
  2. Say "the configured bot" instead of @egg → ✓ Documentation updated (lines 17, 218)

Changes Reviewed

Workflow (on-mention.yml):

  • mention_patterns description example: @mybot,@egg@mybot
  • Default value: @james-in-a-box,@egg@james-in-a-box
  • Fallback in resolve-inputs job: same change

Documentation (github-automation.md):

  • Overview table: `@egg` in issues/PR commentsBot mention in issues/PR comments
  • Section text: mentions @egg or @james-in-a-boxmentions the configured bot

All changes are consistent and complete. The workflow will no longer respond to @egg mentions by default, and the documentation now correctly describes the behavior as depending on the configured mention_patterns input rather than hardcoded names.

— Authored by egg

@james-in-a-box

Copy link
Copy Markdown
Contributor Author

egg review completed. View run logs

@jwbron
jwbron merged commit 44f2cce into main Feb 10, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant